From: Wu Fengguang <fengguang.wu@intel.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Jens Axboe <jens.axboe@oracle.com>
Cc: Jan Kara <jack@suse.cz>, Theodore Ts'o <tytso@mit.edu>,
Dave Chinner <david@fromorbit.com>,
Chris Mason <chris.mason@oracle.com>,
Christoph Hellwig <hch@infradead.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/6 -v2] writeback: balance_dirty_pages() shall write more than dirtied pages
Date: Wed, 23 Sep 2009 21:58:07 +0800 [thread overview]
Message-ID: <20090923135807.GA11607@localhost> (raw)
In-Reply-To: <20090923135600.GA11463@localhost>
On Wed, Sep 23, 2009 at 09:56:00PM +0800, Wu Fengguang wrote:
> -static inline long sync_writeback_pages(void)
> +static inline long sync_writeback_pages(unsigned long dirtied)
> {
> - return ratelimit_pages + ratelimit_pages / 2;
> + if (dirtied < ratelimit_pages)
> + dirtied = ratelimit_pages;
Just added the above checks. Now balance_dirty_pages() for XFS
works in a much larger 1536 chunk size :)
[ 40.374081] redirty_tail() +516: inode=131
[ 40.374951] mm/page-writeback.c +543 balance_dirty_pages(): comm=cp pid=3296 n=1536
[ 40.377001] global dirty=49818 writeback=17027 nfs=0 flags=CM towrite=0 skipped=0
> +
> + return dirtied + dirtied / 2;
> }
Thanks,
Fengguang
next prev parent reply other threads:[~2009-09-23 13:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090923123337.990689487@intel.com>
[not found] ` <20090923124027.456325340@intel.com>
2009-09-23 12:45 ` [PATCH 1/6] writeback: balance_dirty_pages() shall write more than dirtied pages Christoph Hellwig
2009-09-23 12:53 ` Wu Fengguang
2009-09-23 13:56 ` [PATCH 1/6 -v2] " Wu Fengguang
2009-09-23 13:58 ` Wu Fengguang [this message]
[not found] ` <20090923124027.589303074@intel.com>
2009-09-23 15:05 ` [PATCH 2/6] writeback: stop background writeback when below background threshold Jens Axboe
2009-09-24 1:24 ` Wu Fengguang
[not found] ` <20090923124028.060887241@intel.com>
2009-09-23 13:20 ` [PATCH 5/6] writeback: don't delay inodes redirtied by a fast dirtier Wu Fengguang
2009-09-23 13:23 ` Christoph Hellwig
2009-09-23 13:40 ` Wu Fengguang
2009-09-26 19:47 ` Christoph Hellwig
2009-09-27 2:02 ` Wu Fengguang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090923135807.GA11607@localhost \
--to=fengguang.wu@intel.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=chris.mason@oracle.com \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=jens.axboe@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).