From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 5/6] writeback: don't delay inodes redirtied by a fast dirtier Date: Sat, 26 Sep 2009 15:47:47 -0400 Message-ID: <20090926194747.GA1593@infradead.org> References: <20090923123337.990689487@intel.com> <20090923124028.060887241@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Andrew Morton , Jens Axboe , Jan Kara , Theodore Tso , Dave Chinner , Chris Mason , Christoph Hellwig , Peter Zijlstra , linux-fsdevel@vger.kernel.org, LKML To: Wu Fengguang Return-path: Received: from bombadil.infradead.org ([18.85.46.34]:56799 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750897AbZIZTr5 (ORCPT ); Sat, 26 Sep 2009 15:47:57 -0400 Content-Disposition: inline In-Reply-To: <20090923124028.060887241@intel.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, Sep 23, 2009 at 08:33:43PM +0800, Wu Fengguang wrote: > So let's distinguish between data redirty and metadata only redirty. > The first one is caused by a busy dirtier, while the latter one could > happen in XFS, NFS, etc. when they are doing delalloc or updating isize. Btw, I'm not sure the existing and preserved behaviour for that case is good. In the worst case the inode writeout gets delayed by another 30 seconds, doubling the window until a file is on disk if it was extended.