From: Andi Kleen <andi@firstfloor.org>
To: Sage Weil <sage@newdream.net>
Cc: Andi Kleen <andi@firstfloor.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, yehuda@newdream.net
Subject: Re: [PATCH 19/21] ceph: ioctls
Date: Fri, 2 Oct 2009 18:36:18 +0200 [thread overview]
Message-ID: <20091002163618.GN1656@one.firstfloor.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0910020840180.16283@cobra.newdream.net>
> Yes. I suspect an explicit
>
> struct in6_addr osd_addr;
> __be16 osd_port;
>
> makes more sense. Then legacy IPv4 addresses can just be represented as
> ::ffff:1.2.3.4. That seems like the simplest route?
You would need to decide internally then if you want to use
the ipv6 socket API (requiring ipv6 to be loaded) or map
manually. Using af_family might be cleaner.
>
> I should similarly update the struct ceph_entity_addr as well (it also
> embeds a sockaddr_in). And/or embed that struct here.
You could also use struct sockaddr_storage, it's designed to contain arbitary
address types (basically it has a lot of padding)
Trap: if you ever copy it out you have to make sure to not leak
kernel memory in the padding of course.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2009-10-02 16:36 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-22 17:38 [PATCH 00/21] ceph distributed file system client Sage Weil
2009-09-22 17:38 ` [PATCH 01/21] ceph: documentation Sage Weil
2009-09-22 17:38 ` [PATCH 02/21] ceph: on-wire types Sage Weil
2009-09-22 17:38 ` [PATCH 03/21] ceph: client types Sage Weil
2009-09-22 17:38 ` [PATCH 04/21] ceph: ref counted buffer Sage Weil
2009-09-22 17:38 ` [PATCH 05/21] ceph: super.c Sage Weil
2009-09-22 17:38 ` [PATCH 06/21] ceph: inode operations Sage Weil
2009-09-22 17:38 ` [PATCH 07/21] ceph: directory operations Sage Weil
2009-09-22 17:38 ` [PATCH 08/21] ceph: file operations Sage Weil
2009-09-22 17:38 ` [PATCH 09/21] ceph: address space operations Sage Weil
2009-09-22 17:38 ` [PATCH 10/21] ceph: MDS client Sage Weil
2009-09-22 17:38 ` [PATCH 11/21] ceph: OSD client Sage Weil
2009-09-22 17:38 ` [PATCH 12/21] ceph: CRUSH mapping algorithm Sage Weil
2009-09-22 17:38 ` [PATCH 13/21] ceph: monitor client Sage Weil
2009-09-22 17:38 ` [PATCH 14/21] ceph: capability management Sage Weil
2009-09-22 17:38 ` [PATCH 15/21] ceph: snapshot management Sage Weil
2009-09-22 17:38 ` [PATCH 16/21] ceph: messenger library Sage Weil
2009-09-22 17:38 ` [PATCH 17/21] ceph: message pools Sage Weil
2009-09-22 17:38 ` [PATCH 18/21] ceph: nfs re-export support Sage Weil
2009-09-22 17:38 ` [PATCH 19/21] ceph: ioctls Sage Weil
2009-09-22 17:38 ` [PATCH 20/21] ceph: debugfs Sage Weil
2009-09-22 17:38 ` [PATCH 21/21] ceph: Kconfig, Makefile Sage Weil
2009-10-02 4:18 ` [PATCH 19/21] ceph: ioctls Andi Kleen
2009-10-02 15:55 ` Sage Weil
2009-10-02 16:36 ` Andi Kleen [this message]
2009-09-30 0:15 ` [PATCH 06/21] ceph: inode operations Andrew Morton
2009-09-30 17:45 ` Sage Weil
2009-12-03 20:27 ` ceph code review Sage Weil
2009-12-03 20:31 ` Andrew Morton
2009-12-03 21:22 ` Randy Dunlap
2009-09-30 0:13 ` [PATCH 05/21] ceph: super.c Andrew Morton
2009-09-30 0:02 ` [PATCH 04/21] ceph: ref counted buffer Andrew Morton
2009-09-22 18:08 ` [PATCH 03/21] ceph: client types Joe Perches
2009-09-29 23:57 ` Andrew Morton
2009-09-30 17:41 ` Sage Weil
2009-09-22 18:01 ` [PATCH 02/21] ceph: on-wire types Joe Perches
2009-09-22 18:21 ` Sage Weil
2009-09-29 23:52 ` Andrew Morton
2009-09-30 17:40 ` Sage Weil
-- strict thread matches above, loose matches on Subject: below --
2009-10-05 22:50 [PATCH 00/21] ceph distributed file system client Sage Weil
2009-10-05 22:50 ` [PATCH 01/21] ceph: documentation Sage Weil
2009-10-05 22:50 ` [PATCH 02/21] ceph: on-wire types Sage Weil
2009-10-05 22:50 ` [PATCH 03/21] ceph: client types Sage Weil
2009-10-05 22:50 ` [PATCH 04/21] ceph: ref counted buffer Sage Weil
2009-10-05 22:50 ` [PATCH 05/21] ceph: super.c Sage Weil
2009-10-05 22:50 ` [PATCH 06/21] ceph: inode operations Sage Weil
2009-10-05 22:50 ` [PATCH 07/21] ceph: directory operations Sage Weil
2009-10-05 22:50 ` [PATCH 08/21] ceph: file operations Sage Weil
2009-10-05 22:50 ` [PATCH 09/21] ceph: address space operations Sage Weil
2009-10-05 22:50 ` [PATCH 10/21] ceph: MDS client Sage Weil
2009-10-05 22:50 ` [PATCH 11/21] ceph: OSD client Sage Weil
2009-10-05 22:50 ` [PATCH 12/21] ceph: CRUSH mapping algorithm Sage Weil
2009-10-05 22:50 ` [PATCH 13/21] ceph: monitor client Sage Weil
2009-10-05 22:50 ` [PATCH 14/21] ceph: capability management Sage Weil
2009-10-05 22:50 ` [PATCH 15/21] ceph: snapshot management Sage Weil
2009-10-05 22:50 ` [PATCH 16/21] ceph: messenger library Sage Weil
2009-10-05 22:50 ` [PATCH 17/21] ceph: message pools Sage Weil
2009-10-05 22:50 ` [PATCH 18/21] ceph: nfs re-export support Sage Weil
2009-10-05 22:50 ` [PATCH 19/21] ceph: ioctls Sage Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091002163618.GN1656@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sage@newdream.net \
--cc=yehuda@newdream.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).