From: Christoph Hellwig <hch@infradead.org>
To: Chris Mason <chris.mason@oracle.com>, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH RFC] Add cache-only generic file read
Date: Mon, 5 Oct 2009 17:58:40 -0400 [thread overview]
Message-ID: <20091005215840.GA31370@infradead.org> (raw)
In-Reply-To: <20091004232023.GA20160@think>
On Sun, Oct 04, 2009 at 07:20:23PM -0400, Chris Mason wrote:
> What does everyone think of adding something like this:
- duplicates too much of generic_file_aio_read. The patch should just
change generic_file_aio_read to a small wrapper for an O_DIRECT
and a buffered version, and btrfs would jsut use the buffered one
directly.
- the name. We use the term buffered for pagecache I/O, not cached,
e.g. generic_file_buffered_write.
- not sure if the invalidations around the core buffered helper
are generic anough to put them into filemap.c. I'd just put them
into btrfs for now, although that part isn't too important.
prev parent reply other threads:[~2009-10-05 21:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-04 23:20 [PATCH RFC] Add cache-only generic file read Chris Mason
2009-10-05 21:58 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091005215840.GA31370@infradead.org \
--to=hch@infradead.org \
--cc=chris.mason@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).