From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH RFC] Add cache-only generic file read Date: Mon, 5 Oct 2009 17:58:40 -0400 Message-ID: <20091005215840.GA31370@infradead.org> References: <20091004232023.GA20160@think> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii To: Chris Mason , linux-fsdevel@vger.kernel.org Return-path: Received: from bombadil.infradead.org ([18.85.46.34]:41165 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752519AbZJEV7Q (ORCPT ); Mon, 5 Oct 2009 17:59:16 -0400 Content-Disposition: inline In-Reply-To: <20091004232023.GA20160@think> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Sun, Oct 04, 2009 at 07:20:23PM -0400, Chris Mason wrote: > What does everyone think of adding something like this: - duplicates too much of generic_file_aio_read. The patch should just change generic_file_aio_read to a small wrapper for an O_DIRECT and a buffered version, and btrfs would jsut use the buffered one directly. - the name. We use the term buffered for pagecache I/O, not cached, e.g. generic_file_buffered_write. - not sure if the invalidations around the core buffered helper are generic anough to put them into filemap.c. I'd just put them into btrfs for now, although that part isn't too important.