From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wu Fengguang Subject: [PATCH 05/45] writeback: remove the always false bdi_cap_writeback_dirty() test Date: Wed, 07 Oct 2009 15:38:23 +0800 Message-ID: <20091007074901.755680773@intel.com> References: <20091007073818.318088777@intel.com> Cc: Theodore Tso , Christoph Hellwig , Dave Chinner , Chris Mason , Peter Zijlstra , "Li Shaohua" , "Myklebust Trond" , "jens.axboe@oracle.com" , Jan Kara , Nick Piggin , , Wu Fengguang To: Andrew Morton Return-path: Cc: LKML Content-Disposition: inline; filename=writeback-remove-memory-bdi.patch Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org This is dead code because no bdi flush thread will be started for !bdi_cap_writeback_dirty bdis. CC: Jens Axboe Signed-off-by: Wu Fengguang --- fs/fs-writeback.c | 18 ------------------ 1 file changed, 18 deletions(-) --- linux.orig/fs/fs-writeback.c 2009-10-06 23:31:59.000000000 +0800 +++ linux/fs/fs-writeback.c 2009-10-06 23:37:57.000000000 +0800 @@ -617,7 +617,6 @@ static void writeback_inodes_wb(struct b struct writeback_control *wbc) { struct super_block *sb = wbc->sb, *pin_sb = NULL; - const int is_blkdev_sb = sb_is_blkdev_sb(sb); const unsigned long start = jiffies; /* livelock avoidance */ spin_lock(&inode_lock); @@ -638,23 +637,6 @@ static void writeback_inodes_wb(struct b continue; } - if (!bdi_cap_writeback_dirty(wb->bdi)) { - redirty_tail(inode); - if (is_blkdev_sb) { - /* - * Dirty memory-backed blockdev: the ramdisk - * driver does this. Skip just this inode - */ - continue; - } - /* - * Dirty memory-backed inode against a filesystem other - * than the kernel-internal bdev filesystem. Skip the - * entire superblock. - */ - break; - } - if (inode->i_state & (I_NEW | I_WILL_FREE)) { requeue_io(inode); continue;