From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nick Piggin <npiggin@suse.de>
Subject: Re: [PATCH 14/45] writeback: quit on wrap for .range_cyclic (afs)
Date: Wed, 7 Oct 2009 12:21:30 +0200
Message-ID: <20091007102130.GQ30316@wotan.suse.de>
References: <20091007074902.913463607@intel.com> <20091007073818.318088777@intel.com> <32495.1254910626@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Wu Fengguang <fengguang.wu@intel.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Theodore Tso <tytso@mit.edu>,
	Christoph Hellwig <hch@infradead.org>,
	Dave Chinner <david@fromorbit.com>,
	Chris Mason <chris.mason@oracle.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Li Shaohua <shaohua.li@intel.com>,
	Myklebust Trond <Trond.Myklebust@netapp.com>,
	"jens.axboe@oracle.com" <jens.axboe@oracle.com>,
	Jan Kara <jack@suse.cz>, linux-fsdevel@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>
To: David Howells <dhowells@redhat.com>
Return-path: <linux-kernel-owner+glk-linux-kernel-3=40m.gmane.org-S1758304AbZJGKWN@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <32495.1254910626@redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

On Wed, Oct 07, 2009 at 11:17:06AM +0100, David Howells wrote:
> Wu Fengguang <fengguang.wu@intel.com> wrote:
> 
> > Convert wbc.range_cyclic to new behavior: when past EOF, abort writeback
> > of the inode, which instructs writeback_single_inode() to delay it for
> > a while if necessary.
> > 
> > It removes one inefficient .range_cyclic IO pattern when writeback_index
> > wraps:
> > 	submit [10000-10100], (wrap), submit [0-100]
> > In which the submitted pages may be consisted of two distant ranges.
> > 
> > It also prevents submitting pointless IO for busy overwriters.
> > 
> > CC: David Howells <dhowells@redhat.com>
> > Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
> 
> Acked-by: David Howells <dhowells@redhat.com>

I don't see why. Then the inode is given less write bandwidth than
those which don't wrap (or wrap on "nice" boundaries).