From mboxrd@z Thu Jan 1 00:00:00 1970 From: Evgeniy Polyakov Subject: Re: [PATCH 09/45] writeback: quit on wrap for .range_cyclic (pohmelfs) Date: Wed, 7 Oct 2009 16:32:11 +0400 Message-ID: <20091007123211.GA29371@ioremap.net> References: <20091007073818.318088777@intel.com> <20091007074902.268825252@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Andrew Morton , Theodore Tso , Christoph Hellwig , Dave Chinner , Chris Mason , Peter Zijlstra , Li Shaohua , Myklebust Trond , "jens.axboe@oracle.com" , Jan Kara , Nick Piggin , linux-fsdevel@vger.kernel.org, LKML To: Wu Fengguang Return-path: Received: from tservice.ru ([195.178.208.66]:46478 "EHLO tservice.net.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932969AbZJGMct (ORCPT ); Wed, 7 Oct 2009 08:32:49 -0400 Content-Disposition: inline In-Reply-To: <20091007074902.268825252@intel.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Hi. On Wed, Oct 07, 2009 at 03:38:27PM +0800, Wu Fengguang (fengguang.wu@intel.com) wrote: > Convert wbc.range_cyclic to new behavior: when past EOF, abort writeback > of the inode, which instructs writeback_single_inode() to delay it for > a while if necessary. > > It removes one inefficient .range_cyclic IO pattern when writeback_index > wraps: > submit [10000-10100], (wrap), submit [0-100] > In which the submitted pages may be consisted of two distant ranges. > > It also prevents submitting pointless IO for busy overwriters. I have no objections against this patchset, since I followed the upstream writeback behaviour and did not personally observe such wraps which would be otherwise handled in a single run. > CC: Evgeniy Polyakov > Signed-off-by: Wu Fengguang -- Evgeniy Polyakov