From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [patch 2/6] fs: no games with DCACHE_UNHASHED Date: Wed, 14 Oct 2009 23:31:40 -0700 (PDT) Message-ID: <20091014.233140.56663130.davem@davemloft.net> References: <20091015044026.319860788@suse.de> <20091015050048.165912589@suse.de> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, raven@themaw.net, torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, mszeredi@suse.cz To: npiggin@suse.de Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:57062 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753666AbZJOGbo (ORCPT ); Thu, 15 Oct 2009 02:31:44 -0400 In-Reply-To: <20091015050048.165912589@suse.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: From: npiggin@suse.de Date: Thu, 15 Oct 2009 15:40:28 +1100 > (this is in -mm) > > Filesystems outside the regular namespace do not have to clear DCACHE_UNHASHED > in order to have a working /proc/$pid/fd/XXX. Nothing in proc prevents the > fd link from being used if its dentry is not in the hash. > > Also, it does not get put into the dcache hash if DCACHE_UNHASHED is clear; > that depends on the filesystem calling d_add or d_rehash. > > So delete the misleading comments and needless code. > > Acked-by: Miklos Szeredi > Signed-off-by: Nick Piggin For networking bits: Acked-by: David S. Miller