From: Christoph Hellwig <hch@lst.de>
To: tyhicks@linux.vnet.ibm.com, kirkland@canonical.com
Cc: linux-fsdevel@vger.kernel.org
Subject: truncate in ecryptfs
Date: Wed, 14 Oct 2009 17:12:21 +0200 [thread overview]
Message-ID: <20091014151221.GA18371@lst.de> (raw)
It looks like ecryptfs calls vmtruncate directly on the lower filesystem,
which is quite wrong. Vmtruncate is only a helper for the filesystem,
and while most filesystems end up calling vmtruncate from their
->setattr implementation if ATTR_SIZE is set there are many that require
additional work. I think ecryptfs needs to got through notify_change()
/ ->setattr if it wants truncate to work reliably and without silent
corruption or leaking blocks on a variety of filesystems.
next reply other threads:[~2009-10-14 15:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-14 15:12 Christoph Hellwig [this message]
2009-10-14 15:37 ` truncate in ecryptfs Tyler Hicks
2009-10-15 4:19 ` [PATCH] eCryptfs: Use notify_change for truncating lower inodes Tyler Hicks
2009-10-15 16:55 ` Dustin Kirkland
2009-10-25 7:22 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091014151221.GA18371@lst.de \
--to=hch@lst.de \
--cc=kirkland@canonical.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tyhicks@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).