Re: Deadlock with nilfs on 2.6.31.4

["Bruno Prémont" <bonbons@linux-vserver.org>]

Hi Ryusuke Konishi,

On Tue, 03 November 2009 Ryusuke Konishi wrote:
> I found the cause of the hang issue reported on ARM targets.
> The following patch would fix the issue.
> 
> It resolved hang problem on my Feroceon based Linux box.
> 
> Could you try if the patch fixes the hang of yours ?
> 
> Thanks,
> Ryusuke Konishi

Seems to fix the issue here as well, at least collectd now does write
its data to the RRD files as well as to the remote system, no frozen
process yet for 2 and a half hours uptime.

Thanks for the fix,
Bruno

Tested-by: Bruno Prémont <bonbons@linux-vserver.org>
> --
> From: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
> 
> nilfs2: fix dirty page accounting leak causing hang at write
> 
> Some users experienced a consistent hang while using NILFS on
> ARM-based targets.
> 
> I found this was caused by an underflow of dirty pages counter.  A
> b-tree cache routine was marking page dirty without adjusting page
> account information.
> 
> This fixes the dirty page accounting leak and resolves the hang on
> arm-based targets.
> 
> Reported-by: Bruno Premont <bonbons@linux-vserver.org>
> Reported-by: Dunphy, Bill <WDunphy@tandbergdata.com>
> Signed-off-by: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
> ---
>  fs/nilfs2/btnode.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/nilfs2/btnode.c b/fs/nilfs2/btnode.c
> index 5941958..435864c 100644
> --- a/fs/nilfs2/btnode.c
> +++ b/fs/nilfs2/btnode.c
> @@ -276,8 +276,7 @@ void nilfs_btnode_commit_change_key(struct
> address_space *btnc, "invalid oldkey %lld (newkey=%lld)",
>  				       (unsigned long long)oldkey,
>  				       (unsigned long long)newkey);
> -		if (!test_set_buffer_dirty(obh) &&
> TestSetPageDirty(opage))
> -			BUG();
> +		nilfs_btnode_mark_dirty(obh);
>  
>  		spin_lock_irq(&btnc->tree_lock);
>  		radix_tree_delete(&btnc->page_tree, oldkey);
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html