From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Serge E. Hallyn" Subject: Re: [PATCH 07/13] sysfs: Update s_iattr on link and unlink. Date: Tue, 3 Nov 2009 22:58:21 -0600 Message-ID: <20091104045821.GB774@us.ibm.com> References: <1257249429-12384-7-git-send-email-ebiederm@xmission.com> <20091104035413.GD27639@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Greg Kroah-Hartman , Kay Sievers , Greg KH , linux-kernel@vger.kernel.org, Tejun Heo , Cornelia Huck , linux-fsdevel@vger.kernel.org, Eric Dumazet , Benjamin LaHaise , "Eric W. Biederman" To: "Eric W. Biederman" Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Quoting Eric W. Biederman (ebiederm@xmission.com): > "Serge E. Hallyn" writes: > > > Quoting Eric W. Biederman (ebiederm@xmission.com): > >> From: Eric W. Biederman > >> > >> Currently sysfs updates the timestamps on the vfs directory > >> inode when we create or remove a directory entry but doesn't > >> update the cached copy on the sysfs_dirent, fix that oversight. > > > > confused... why not do this in sysfs_addrm_finish()? > > > > I guess you'd have to do at it at top before dropping sysfs_mutex > > so it wouldn't be as pretty as I was thinking, but at least you > > could just do it once. > > Well sysfs_addrm_finish doesn't really know if you did anything. Oh right - well it used to through cnt right? but not after your last patch. > Beyond that my ultimate goal is to kill sysfs_addrm_start and > sysfs_addrm_finish. Of course that requires fixing all of the > sysfs users that depend on the impossible to get right recursive > directory removal in sysfs, so it is not the subject of this patchset. I didn't see the patch nixing inode->i_mtime (and cnt) changing from sysfs_addrm_finish() until after responding. Got it now. Acked-by: Serge Hallyn -serge