From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH 1/2] sanitize xattr handler prototypes Date: Tue, 10 Nov 2009 12:19:41 -0800 Message-ID: <20091110121941.c814d4c9.akpm@linux-foundation.org> References: <20091103154448.GB23101@lst.de> <1257268307.6052.764.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Christoph Hellwig , viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org To: Steven Whitehouse Return-path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:41262 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758055AbZKJUUO (ORCPT ); Tue, 10 Nov 2009 15:20:14 -0500 In-Reply-To: <1257268307.6052.764.camel@localhost.localdomain> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue, 03 Nov 2009 17:11:47 +0000 Steven Whitehouse wrote: > Hi, > > On Tue, 2009-11-03 at 16:44 +0100, Christoph Hellwig wrote: > > Add a flags argument to strcut xattr_handler and pass it to all xattr > > handler methods. This allows using the same methods for multiple > > handlers, e.g. for the ACL methods which perform exactly the same action > > for the access and default ACLs, just using a different underlying > > attribute. With a little more groundwork it'll also allow sharing the > > methods for the regular user/trusted/secure handlers in extN, ocfs2 and > > jffs2 like it's already done for xfs in this patch. > > > > Also change the inode argument to the handlers to a dentry to allow > > using the handlers mechnism for filesystems that require it later, > > e.g. cifs. > > > > Signed-off-by: Christoph Hellwig > > Reviewed-by: James Morris > > Acked-by: Joel Becker > > > GFS2 bits Acked-by: Steven Whitehouse > GFS2 bits Buggered-up-by: Steven Whitehouse patching file fs/gfs2/acl.c Hunk #1 FAILED at 185. Hunk #2 FAILED at 196. Hunk #3 FAILED at 205. Hunk #4 FAILED at 217. Hunk #5 FAILED at 231. 5 out of 5 hunks FAILED -- saving rejects to file fs/gfs2/acl.c.rej patching file fs/gfs2/inode.c patching file fs/gfs2/xattr.c Hunk #1 succeeded at 567 (offset 30 lines). Hunk #2 succeeded at 1118 (offset 30 lines). Hunk #3 succeeded at 1129 (offset 30 lines). Hunk #4 succeeded at 1154 (offset 30 lines). Hunk #5 succeeded at 1182 (offset 30 lines). Hunk #6 succeeded at 1222 (offset 30 lines). Hunk #7 FAILED at 1530. 1 out of 7 hunks FAILED -- saving rejects to file fs/gfs2/xattr.c.rej linux-next changes have made rather a mess of this patch.