From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wu Fengguang Subject: Re: [PATCH] vfs: Add a trace point in the mark_inode_dirty function Date: Wed, 11 Nov 2009 10:01:08 +0800 Message-ID: <20091111020108.GA11423@localhost> References: <20091025225342.007138f5@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Christoph Hellwig , Al Viro , mingo@elte.hu, Frederic Weisbecker , auke-jan.h.kok@intel.com To: Arjan van de Ven Return-path: Content-Disposition: inline In-Reply-To: <20091025225342.007138f5@infradead.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Hi Arjan, > + TP_printk("task=%i (%s) file=%s dev=%s", > + __entry->pid, __entry->comm, __entry->file, __entry->dev) Maybe this is enough for POWERTOP, however for general use, the dirty type(data/metadata) and inode number may be valuable to some users? Thanks, Fengguang