From: Wu Fengguang <fengguang.wu@intel.com>
To: Arjan van de Ven <arjan@infradead.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
Christoph Hellwig <hch@infradead.org>,
Al Viro <viro@ZenIV.linux.org.uk>,
"mingo@elte.hu" <mingo@elte.hu>,
Frederic Weisbecker <fweisbec@gmail.com>,
"Kok, Auke-jan H" <auke-jan.h.kok@intel.com>
Subject: Re: [PATCH] vfs: Add a trace point in the mark_inode_dirty function
Date: Wed, 11 Nov 2009 14:40:27 +0800 [thread overview]
Message-ID: <20091111064027.GA11565@localhost> (raw)
In-Reply-To: <20091110223456.01ef355f@infradead.org>
On Wed, Nov 11, 2009 at 02:34:56PM +0800, Arjan van de Ven wrote:
> On Wed, 11 Nov 2009 10:01:08 +0800
> Wu Fengguang <fengguang.wu@intel.com> wrote:
>
> > Hi Arjan,
> >
> > > + TP_printk("task=%i (%s) file=%s dev=%s",
> > > + __entry->pid, __entry->comm, __entry->file,
> > > __entry->dev)
> >
> > Maybe this is enough for POWERTOP, however for general use, the dirty
> > type(data/metadata) and inode number may be valuable to some users?
>
> what can a user do with an inode number????
Hmm, maybe to tell one file from another in the trace stream :)
And maybe to compare it with other data sources, like "ls -i".
Thanks,
Fengguang
next prev parent reply other threads:[~2009-11-11 6:40 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-26 5:53 [PATCH] vfs: Add a trace point in the mark_inode_dirty function Arjan van de Ven
2009-10-26 6:03 ` Andrew Morton
2009-10-26 6:55 ` Arjan van de Ven
2009-10-27 16:01 ` Jason Baron
2009-11-11 2:01 ` Wu Fengguang
2009-11-11 6:34 ` Arjan van de Ven
2009-11-11 6:40 ` Wu Fengguang [this message]
2009-11-11 7:42 ` Jeff Garzik
2009-11-11 7:45 ` Ingo Molnar
2009-11-11 7:56 ` Jeff Garzik
2009-11-11 11:15 ` Ingo Molnar
2009-11-11 17:27 ` Kok, Auke
2009-11-11 18:29 ` Theodore Tso
2009-11-11 18:56 ` Ingo Molnar
2009-11-12 2:15 ` Arjan van de Ven
2009-11-11 16:19 ` Arjan van de Ven
2009-11-11 23:10 ` Frank Ch. Eigler
2009-11-11 23:37 ` Kok, Auke
2009-11-12 7:22 ` Ingo Molnar
2009-11-20 10:43 ` Christoph Hellwig
2009-11-20 10:51 ` Ingo Molnar
2009-11-20 14:45 ` Arjan van de Ven
2009-11-20 16:05 ` Jamie Lokier
2009-11-20 16:45 ` Arjan van de Ven
2009-11-11 2:33 ` Li Zefan
2009-11-15 19:00 ` Arjan van de Ven
2009-11-16 0:56 ` Li Zefan
-- strict thread matches above, loose matches on Subject: below --
2010-11-26 20:56 Arjan van de Ven
2010-11-28 17:52 ` Christoph Hellwig
2010-11-28 18:43 ` Arjan van de Ven
2010-11-29 1:41 ` KOSAKI Motohiro
2010-11-29 4:54 ` Arjan van de Ven
2010-11-29 5:15 ` KOSAKI Motohiro
2010-11-29 14:21 ` Steven Rostedt
2010-11-29 14:41 ` Mathieu Desnoyers
2010-11-29 16:31 ` Steven Rostedt
2010-11-30 0:37 ` KOSAKI Motohiro
2010-11-29 3:53 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091111064027.GA11565@localhost \
--to=fengguang.wu@intel.com \
--cc=arjan@infradead.org \
--cc=auke-jan.h.kok@intel.com \
--cc=fweisbec@gmail.com \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).