From: akpm@linux-foundation.org
To: viro@zeniv.linux.org.uk
Cc: linux-fsdevel@vger.kernel.org, akpm@linux-foundation.org,
jlayton@redhat.com, hch@lst.de
Subject: [patch 9/9] vfs: remove extraneous NULL d_inode check from do_filp_open
Date: Tue, 17 Nov 2009 14:56:35 -0800 [thread overview]
Message-ID: <200911172256.nAHMuZpk027819@imap1.linux-foundation.org> (raw)
From: Jeff Layton <jlayton@redhat.com>
We can't get to this point unless it's a valid pointer.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
fs/namei.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN fs/namei.c~vfs-remove-extraneous-null-d_inode-check-from-do_filp_open fs/namei.c
--- a/fs/namei.c~vfs-remove-extraneous-null-d_inode-check-from-do_filp_open
+++ a/fs/namei.c
@@ -1818,7 +1818,7 @@ do_last:
path_to_nameidata(&path, &nd);
error = -EISDIR;
- if (path.dentry->d_inode && S_ISDIR(path.dentry->d_inode->i_mode))
+ if (S_ISDIR(path.dentry->d_inode->i_mode))
goto exit;
ok:
/*
_
next reply other threads:[~2009-11-17 23:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-17 22:56 akpm [this message]
2009-12-02 10:09 ` [patch 9/9] vfs: remove extraneous NULL d_inode check from do_filp_open Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200911172256.nAHMuZpk027819@imap1.linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hch@lst.de \
--cc=jlayton@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).