From mboxrd@z Thu Jan 1 00:00:00 1970 From: akpm@linux-foundation.org Subject: [patch 9/9] vfs: remove extraneous NULL d_inode check from do_filp_open Date: Tue, 17 Nov 2009 14:56:35 -0800 Message-ID: <200911172256.nAHMuZpk027819@imap1.linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Cc: linux-fsdevel@vger.kernel.org, akpm@linux-foundation.org, jlayton@redhat.com, hch@lst.de To: viro@zeniv.linux.org.uk Return-path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:35480 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756636AbZKQXG1 (ORCPT ); Tue, 17 Nov 2009 18:06:27 -0500 Sender: linux-fsdevel-owner@vger.kernel.org List-ID: From: Jeff Layton We can't get to this point unless it's a valid pointer. Signed-off-by: Jeff Layton Cc: Al Viro Cc: Christoph Hellwig Signed-off-by: Andrew Morton --- fs/namei.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN fs/namei.c~vfs-remove-extraneous-null-d_inode-check-from-do_filp_open fs/namei.c --- a/fs/namei.c~vfs-remove-extraneous-null-d_inode-check-from-do_filp_open +++ a/fs/namei.c @@ -1818,7 +1818,7 @@ do_last: path_to_nameidata(&path, &nd); error = -EISDIR; - if (path.dentry->d_inode && S_ISDIR(path.dentry->d_inode->i_mode)) + if (S_ISDIR(path.dentry->d_inode->i_mode)) goto exit; ok: /* _