From mboxrd@z Thu Jan  1 00:00:00 1970
From: Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH 1/2] BKL: Remove BKL from default_llseek()
Date: Wed, 18 Nov 2009 20:17:26 +0100
Message-ID: <200911182017.26266.arnd@arndb.de>
References: <1258560457-15129-1-git-send-email-jblunck@suse.de> <200911181833.37531.arnd@arndb.de> <20091118181433.50b1b707@lxorguk.ukuu.org.uk>
Mime-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Cc: Jamie Lokier <jamie@shareable.org>, Jan Blunck <jblunck@suse.de>,
	linux-fsdevel@vger.kernel.org,
	"Linux-Kernel Mailinglist" <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>, jkacur@redhat.com,
	Thomas Gleixner <tglx@linutronix.de>,
	Christoph Hellwig <hch@infradead.org>,
	=?iso-8859-1?q?Fr=E9d=E9ric_Weisbecker?= <fweisbec@gmail.com>,
	Alexander Viro <viro@zeniv.linux.org.uk>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Return-path: <linux-kernel-owner+glk-linux-kernel-3=40m.gmane.org-S932630AbZKRTST@vger.kernel.org>
In-Reply-To: <20091118181433.50b1b707@lxorguk.ukuu.org.uk>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

On Wednesday 18 November 2009, Alan Cox wrote:
> Stuff that looks trivial to salvage and works if you don't pread/write I
> imagine
> 
> drivers/sbus/char/flash.c

It also breaks if you do consecutive read() operations without an lseek
between them, because read() does not update *pos. It should work if you
read the whole thing with a single read() operation though, like
the other drivers you mentioned.

	Arnd <><