From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Mason <chris.mason@oracle.com>
Subject: Re: btrfs: possible unit mismatch on the async_delalloc_pages limit
Date: Wed, 18 Nov 2009 17:04:30 -0500
Message-ID: <20091118220430.GD3110@think>
References: <20091118085132.GA9049@localhost>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: linux-fsdevel@vger.kernel.org
To: Wu Fengguang <fengguang.wu@intel.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from acsinet11.oracle.com ([141.146.126.233]:36189 "EHLO
	acsinet11.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1756117AbZKRWEz (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Wed, 18 Nov 2009 17:04:55 -0500
Content-Disposition: inline
In-Reply-To: <20091118085132.GA9049@localhost>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Wed, Nov 18, 2009 at 04:51:32PM +0800, Wu Fengguang wrote:
> Hi Chris,
> 
> I suspect the async_delalloc_pages limit checking in btrfs/inode.c
> 
>         atomic_read(&root->fs_info->async_delalloc_pages) < 5 * 1042 * 1024
> 
> never evaluate to FALSE because 5M pages are 20GB which is super
> large. I tried to fix it with the following patch. I increased the
> limit a bit, however still worry that the "corrected" limit is too
> small to create some regressions.
> 
> What do you think?

Thanks, I'll give this a shot here.

-chris