From: Wu Fengguang <fengguang.wu@intel.com>
To: Evgeniy Polyakov <zbr@ioremap.net>,
Andrew Morton <akpm@linux-foundation.org>,
Jens Axboe <jens.axboe@oracle.com>
Cc: "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 03/12] writeback: remove unused nonblocking and congestion checks (pohmelfs)
Date: Thu, 19 Nov 2009 16:11:54 +0800 [thread overview]
Message-ID: <20091119081154.GE5922@localhost> (raw)
In-Reply-To: <20091118082845.828021716@intel.com>
Hi Evgeniy,
Will you pick up this updated patch? It also removes the unused bdi.
Thanks,
Fengguang
---
writeback: remove unused nonblocking and congestion checks (pohmelfs)
No one is calling wb_writeback and write_cache_pages with
wbc.nonblocking=1 any more. And lumpy pageout will want to do
nonblocking writeback without the congestion wait.
CC: Evgeniy Polyakov <zbr@ioremap.net>
Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
---
drivers/staging/pohmelfs/inode.c | 10 ----------
1 file changed, 10 deletions(-)
--- linux.orig/drivers/staging/pohmelfs/inode.c 2009-11-18 16:39:36.000000000 +0800
+++ linux/drivers/staging/pohmelfs/inode.c 2009-11-19 16:10:29.000000000 +0800
@@ -143,7 +143,6 @@ static int pohmelfs_writepages(struct ad
struct inode *inode = mapping->host;
struct pohmelfs_inode *pi = POHMELFS_I(inode);
struct pohmelfs_sb *psb = POHMELFS_SB(inode->i_sb);
- struct backing_dev_info *bdi = mapping->backing_dev_info;
int err = 0;
int done = 0;
int nr_pages;
@@ -152,11 +151,6 @@ static int pohmelfs_writepages(struct ad
int scanned = 0;
int range_whole = 0;
- if (wbc->nonblocking && bdi_write_congested(bdi)) {
- wbc->encountered_congestion = 1;
- return 0;
- }
-
if (wbc->range_cyclic) {
index = mapping->writeback_index; /* Start from prev offset */
end = -1;
@@ -248,10 +242,6 @@ retry:
if (wbc->nr_to_write <= 0)
done = 1;
- if (wbc->nonblocking && bdi_write_congested(bdi)) {
- wbc->encountered_congestion = 1;
- done = 1;
- }
continue;
out_continue:
next prev parent reply other threads:[~2009-11-19 8:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20091118082648.140755818@intel.com>
[not found] ` <20091118082846.170413359@intel.com>
2009-11-18 9:59 ` [PATCH 06/12] writeback: remove unused nonblocking and congestion checks (gfs2) Steven Whitehouse
2009-11-18 10:09 ` Wu Fengguang
2009-11-18 11:13 ` Steven Whitehouse
[not found] ` <20091118082846.921451469@intel.com>
2009-11-18 10:38 ` [PATCH 12/12] bdi: use bdi_stat_sum() for more accurate debugfs stats Peter Zijlstra
2009-11-19 7:59 ` Wu Fengguang
2009-11-19 8:12 ` Peter Zijlstra
2009-11-19 8:17 ` Wu Fengguang
[not found] ` <20091118082846.279046849@intel.com>
2009-11-18 21:27 ` [PATCH 07/12] writeback: remove unused nonblocking and congestion checks (xfs) Dave Chinner
2009-11-19 8:05 ` Wu Fengguang
2009-11-20 7:24 ` Dave Chinner
[not found] ` <20091118082845.828021716@intel.com>
2009-11-19 8:11 ` Wu Fengguang [this message]
2009-11-19 11:04 ` [PATCH 03/12] writeback: remove unused nonblocking and congestion checks (pohmelfs) Evgeniy Polyakov
2009-11-20 1:53 ` Wu Fengguang
2009-11-21 11:23 ` Evgeniy Polyakov
[not found] ` <20091118082845.936295466@intel.com>
2009-11-19 8:09 ` [PATCH 04/12] writeback: remove unused nonblocking and congestion checks (afs) Wu Fengguang
2009-11-19 16:51 ` David Howells
[not found] ` <20091118082846.404788666@intel.com>
2009-11-24 16:18 ` [PATCH 08/12] ext4: remove encountered_congestion trace tytso
[not found] ` <20091118082846.530386547@intel.com>
2009-11-24 16:18 ` [PATCH 09/12] ext4: remove unused parameter wbc from __ext4_journalled_writepage() tytso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091119081154.GE5922@localhost \
--to=fengguang.wu@intel.com \
--cc=akpm@linux-foundation.org \
--cc=jens.axboe@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).