From: Jamie Lokier <jamie@shareable.org>
To: Jan Blunck <jblunck@suse.de>
Cc: linux-fsdevel@vger.kernel.org,
"Christoph Hellwig" <hch@infradead.org>,
"Alan Cox" <alan@lxorguk.ukuu.org.uk>,
"Linux-Kernel Mailinglist" <linux-kernel@vger.kernel.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
jkacur@redhat.com, "Arnd Bergmann" <arnd@arndb.de>,
"Frédéric Weisbecker" <fweisbec@gmail.com>,
"Willem Riede" <osst@riede.org>,
"James E.J. Bottomley" <James.Bottomley@suse.de>
Subject: Re: [PATCH 03/15] osst: Update ppos instead of using file->f_pos
Date: Fri, 20 Nov 2009 17:16:56 +0000 [thread overview]
Message-ID: <20091120171656.GI20634@shareable.org> (raw)
In-Reply-To: <20091120171317.GH20634@shareable.org>
Jamie Lokier wrote:
> Jan Blunck wrote:
> > osst_read()/osst_write() modify file->f_pos directly instead of the ppos
> > given to them. The VFS later updates the file->f_pos and overwrites it
> > with the value of ppos.
>
> I notice st.c doesn't use or update file->f_pos (or *ppos), so
> userspace probably won't be caring about f_pos from osst.c (they're
> both SCSI tape drivers). And osst.c doesn't use the value, it just
> increases it with each transfer. It doesn't even reset the value to
> zero when rewinding the tape, so it's not that meaningful.
>
> So how about just removing those modifications to file->f_pos from osst.c?
Or alternatively, perhaps they are missing from st.c. I don't know,
but userspace can't have been all that dependent on the value :-)
-- Jamie
next prev parent reply other threads:[~2009-11-20 17:16 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-20 16:40 [PATCH 00/15] Remove BKL from default_llseek() and other issues (v2) Jan Blunck
2009-11-20 16:40 ` [PATCH 01/15] Introduce noop_llseek() Jan Blunck
2009-11-20 17:05 ` Jamie Lokier
2009-11-20 17:11 ` Jan Blunck
2009-11-21 16:56 ` Arnd Bergmann
2009-11-20 16:40 ` [PATCH 02/15] osst: Use noop_llseek() instead of default_llseek() Jan Blunck
2009-11-20 17:09 ` Jamie Lokier
2009-11-20 17:25 ` Jan Blunck
2009-11-20 16:40 ` [PATCH 03/15] osst: Update ppos instead of using file->f_pos Jan Blunck
2009-11-20 17:13 ` Jamie Lokier
2009-11-20 17:16 ` Jamie Lokier [this message]
2009-11-20 16:40 ` [PATCH 04/15] s390: tape_char should update " Jan Blunck
2009-11-20 16:40 ` [PATCH 05/15] flash_read should update ppos instead of file->f_pos Jan Blunck
2009-11-20 16:40 ` [PATCH 06/15] eeprom_read()/eeprom_write() " Jan Blunck
2009-11-20 16:40 ` [PATCH 07/15] sched_feat_write: Update " Jan Blunck
2009-11-20 16:40 ` [PATCH 08/15] airo: Use " Jan Blunck
2009-11-20 16:40 ` [PATCH 09/15] frv: remove "struct file *" argument from sysctl ->proc_handler Jan Blunck
2009-11-20 16:40 ` [PATCH 10/15] mISDN: Remove unnecessary test on f_pos Jan Blunck
2009-11-20 16:40 ` [PATCH 11/15] zcrypt: Use nonseekable_open() Jan Blunck
2009-11-20 16:40 ` [PATCH 12/15] rtc-m41t80: " Jan Blunck
2009-11-20 16:40 ` [PATCH 13/15] Do not fallback to default_llseek() when readdir() uses BKL Jan Blunck
2009-11-20 21:27 ` Jan Kara
2009-11-21 18:03 ` Anders Larsen
2009-11-20 16:40 ` [PATCH 14/15] BKL: Remove BKL from default_llseek() Jan Blunck
2009-11-20 16:40 ` [PATCH 15/15] BKL: Update documentation on llseek( \b) Jan Blunck
2009-11-20 17:02 ` [PATCH 15/15] BKL: Update documentation on llseek(\b) Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091120171656.GI20634@shareable.org \
--to=jamie@shareable.org \
--cc=James.Bottomley@suse.de \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=arnd@arndb.de \
--cc=fweisbec@gmail.com \
--cc=hch@infradead.org \
--cc=jblunck@suse.de \
--cc=jkacur@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=osst@riede.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).