From: "Liuweni" <qingshenlwy@gmail.com>
To: "linux-kernel" <linux-kernel@vger.kernel.org>
Cc: "strongzgy" <strongzgy@gmail.com>, "xgr178" <xgr178@163.com>,
"Liu Hui" <onlyflyer@gmail.com>, "viro" <viro@zeniv.linux.org.uk>,
"akpm" <akpm@linux-foundation.org>, "jack" <jack@suse.cz>,
"npiggin" <npiggin@suse.de>,
"linux-fsdevel" <linux-fsdevel@vger.kernel.org>,
"linux-kernel" <linux-kernel@vger.kernel.org>
Subject: [PATCH 1/3]fs/inode: iunique() Optimize Performance
Date: Wed, 25 Nov 2009 22:09:45 +0800 [thread overview]
Message-ID: <200911252209432039291@gmail.com> (raw)
---
move the if condition out the while{}.
While the function executing, the if
condition won't check again and again.
And this code won't change the function
of iunique().
---
Signed-off-by: Liuwenyi<qingshenlwy@gmail.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Jan Kara <jack@suse.cz>
Cc: Nick Piggin <npiggin@suse.de>
Cc: linux-fsdevel@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
diff --git a/fs/inode.c b/fs/inode.c
index 4d8e3be..8ff1e99 100644
--- a/fs/inode.c
+++ b/fs/inode.c
@@ -838,9 +838,10 @@ ino_t iunique(struct super_block *sb, ino_t max_reserved)
ino_t res;
spin_lock(&inode_lock);
+
+ if (counter <= max_reserved)
+ counter = max_reserved + 1;
do {
- if (counter <= max_reserved)
- counter = max_reserved + 1;
res = counter++;
head = inode_hashtable + hash(sb, res);
inode = find_inode_fast(sb, head, res);
--------------
Best Regards,
Liuweni
2009-11-25
next reply other threads:[~2009-11-25 14:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-25 14:09 Liuweni [this message]
2009-11-25 14:15 ` [PATCH 1/3]fs/inode: iunique() Optimize Performance Matthew Wilcox
2009-11-25 19:20 ` Jérémy Cochoy
2009-11-25 19:52 ` Matthew Wilcox
2009-12-01 5:01 ` liu weni
2009-12-01 12:03 ` Matthew Wilcox
2009-12-01 13:21 ` Liuweni
2009-12-01 14:00 ` Matthew Wilcox
2009-12-02 9:42 ` Nick Piggin
2009-11-25 14:51 ` Liuweni
2009-11-25 14:54 ` Matthew Wilcox
2009-11-25 15:06 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200911252209432039291@gmail.com \
--to=qingshenlwy@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=npiggin@suse.de \
--cc=onlyflyer@gmail.com \
--cc=strongzgy@gmail.com \
--cc=viro@zeniv.linux.org.uk \
--cc=xgr178@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).