From: "Liuweni" <qingshenlwy@gmail.com>
To: "linux-kernel" <linux-kernel@vger.kernel.org>
Cc: "viro" <viro@zeniv.linux.org.uk>,
"akpm" <akpm@linux-foundation.org>, "jack" <jack@suse.cz>,
"npiggin" <npiggin@suse.de>,
"linux-fsdevel" <linux-fsdevel@vger.kernel.org>,
"linux-kernel" <linux-kernel@vger.kernel.org>,
"strongzgy" <strongzgy@gmail.com>, "xgr178" <xgr178@163.com>,
"Liu Hui" <onlyflyer@gmail.com>
Subject: [PATCH 2/3]fs/inode: iunique() Optimize Performance
Date: Wed, 25 Nov 2009 22:12:19 +0800 [thread overview]
Message-ID: <200911252212166092236@gmail.com> (raw)
---
Change log:
Change the hash operation from division to shift. It will cost less time.
Also, I change the divisor from L1_CACHE_BYTES to L1_CACHE_SHIFT.
In the cache.h, the most L1_CACHE_BYTES defined as "(1 << L1_CACHE_SHIFT)".
---
Signed-off-by: Liuwenyi<qingshenlwy@gmail.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Jan Kara <jack@suse.cz>
Cc: Nick Piggin <npiggin@suse.de>
Cc: linux-fsdevel@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
diff --git a/fs/inode.c b/fs/inode.c
index 4d8e3be..397d65f 100644
--- a/fs/inode.c
+++ b/fs/inode.c
@@ -605,8 +605,8 @@ static unsigned long hash(struct super_block *sb, unsigned long hashval)
{
unsigned long tmp;
- tmp = (hashval * (unsigned long)sb) ^ (GOLDEN_RATIO_PRIME + hashval) /
- L1_CACHE_BYTES;
+ tmp = (hashval * (unsigned long)sb) ^ (GOLDEN_RATIO_PRIME + hashval) >>
+ L1_CACHE_SHIFT;
tmp = tmp ^ ((tmp ^ GOLDEN_RATIO_PRIME) >> I_HASHBITS);
return tmp & I_HASHMASK;
}
--------------
Best Regards,
Liuweni
2009-11-25
next reply other threads:[~2009-11-25 14:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-25 14:12 Liuweni [this message]
2009-11-25 14:17 ` [PATCH 2/3]fs/inode: iunique() Optimize Performance Matthew Wilcox
2009-11-25 14:45 ` Américo Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200911252212166092236@gmail.com \
--to=qingshenlwy@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=npiggin@suse.de \
--cc=onlyflyer@gmail.com \
--cc=strongzgy@gmail.com \
--cc=viro@zeniv.linux.org.uk \
--cc=xgr178@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).