From: Amerigo Wang <amwang@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Matthew Wilcox <matthew@wil.cx>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Jonathan Corbet <corbet@lwn.net>, Oleg Nesterov <oleg@redhat.com>,
Christoph Hellwig <hch@lst.de>, Amerigo Wang <amwang@redhat.com>,
linux-fsdevel@vger.kernel.org, akpm@linux-foundation.org
Subject: [Patch] fs: move a definition out of switch block
Date: Mon, 30 Nov 2009 04:36:30 -0500 [thread overview]
Message-ID: <20091130093929.4559.4449.sendpatchset@localhost.localdomain> (raw)
It's not a good practice to leave a definition between
'switch' and the its first label.
Move it out of the switch block.
Signed-off-by: WANG Cong <amwang@redhat.com>
Cc: Matthew Wilcox <matthew@wil.cx>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>
---
diff --git a/fs/fcntl.c b/fs/fcntl.c
index 2cf93ec..23b0238 100644
--- a/fs/fcntl.c
+++ b/fs/fcntl.c
@@ -514,12 +514,12 @@ static void send_sigio_to_task(struct task_struct *p,
* sure we read it once and use the same value throughout.
*/
int signum = ACCESS_ONCE(fown->signum);
+ siginfo_t si;
if (!sigio_perm(p, fown, signum))
return;
switch (signum) {
- siginfo_t si;
default:
/* Queue a rt signal with the appropriate fd as its
value. We use SI_SIGIO as the source, not
reply other threads:[~2009-11-30 9:36 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091130093929.4559.4449.sendpatchset@localhost.localdomain \
--to=amwang@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=oleg@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).