linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [Patch] fs: move a definition out of switch block
@ 2009-11-30  9:36 Amerigo Wang
  0 siblings, 0 replies; only message in thread
From: Amerigo Wang @ 2009-11-30  9:36 UTC (permalink / raw)
  To: linux-kernel
  Cc: Matthew Wilcox, Alexander Viro, Jonathan Corbet, Oleg Nesterov,
	Christoph Hellwig, Amerigo Wang, linux-fsdevel, akpm


It's not a good practice to leave a definition between
'switch' and the its first label.

Move it out of the switch block.

Signed-off-by: WANG Cong <amwang@redhat.com>
Cc: Matthew Wilcox <matthew@wil.cx>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>

---
diff --git a/fs/fcntl.c b/fs/fcntl.c
index 2cf93ec..23b0238 100644
--- a/fs/fcntl.c
+++ b/fs/fcntl.c
@@ -514,12 +514,12 @@ static void send_sigio_to_task(struct task_struct *p,
 	 * sure we read it once and use the same value throughout.
 	 */
 	int signum = ACCESS_ONCE(fown->signum);
+	siginfo_t si;
 
 	if (!sigio_perm(p, fown, signum))
 		return;
 
 	switch (signum) {
-		siginfo_t si;
 		default:
 			/* Queue a rt signal with the appropriate fd as its
 			   value.  We use SI_SIGIO as the source, not 

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2009-11-30  9:36 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-30  9:36 [Patch] fs: move a definition out of switch block Amerigo Wang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).