From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Ingo Molnar <mingo@elte.hu>
Cc: David Howells <dhowells@redhat.com>,
torvalds@osdl.org, akpm@linux-foundation.org, steved@redhat.com,
jens.axboe@oracle.com, linux-cachefs@redhat.com,
nfsv4@linux-nfs.org, linux-fsdevel@vger.kernel.org,
cluster-devel@redhat.com, linux-kernel@vger.kernel.org,
linux-cifs-client@lists.samba.org, linux-next@vger.kernerl.org
Subject: Re: [PATCH] slow-work: Fix build bug in the !CONFIG_MODULES case
Date: Tue, 1 Dec 2009 18:32:01 +1100 [thread overview]
Message-ID: <20091201183201.0c56f119.sfr@canb.auug.org.au> (raw)
In-Reply-To: <20091201065605.GA5361@elte.hu>
[-- Attachment #1: Type: text/plain, Size: 1063 bytes --]
Hi Ingo,
On Tue, 1 Dec 2009 07:56:05 +0100 Ingo Molnar <mingo@elte.hu> wrote:
>
> these slow-work changes have introduced a new !CONFIG_MODULES build bug
> on x86 (and all other architectures i suspect):
Thanks for the heads up!
> From: Ingo Molnar <mingo@elte.hu>
> Date: Tue, 1 Dec 2009 07:47:52 +0100
> Subject: [PATCH] slow-work: Fix build bug in the !CONFIG_MODULES case
>
> Commit 3bde31a ("SLOW_WORK: Allow a requeueable work item to sleep till
> the thread is needed") broke the !CONFIG_MODULES build by relying on
> variables that are only available (and only make sense) with module
> support enabled. Fix it.
>
> Cc: David Howells <dhowells@redhat.com>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Ingo Molnar <mingo@elte.hu>
I have applied this to linux-next for today, just so people don't waste
their time finding this breakage again.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
prev parent reply other threads:[~2009-12-01 7:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-20 10:48 [GIT PULL] Fix bugs in Slow-work, FS-Cache and CacheFiles David Howells
2009-11-20 23:01 ` [GIT PULL v2] " David Howells
2009-12-01 6:56 ` [PATCH] slow-work: Fix build bug in the !CONFIG_MODULES case Ingo Molnar
2009-12-01 7:32 ` Stephen Rothwell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091201183201.0c56f119.sfr@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=akpm@linux-foundation.org \
--cc=cluster-devel@redhat.com \
--cc=dhowells@redhat.com \
--cc=jens.axboe@oracle.com \
--cc=linux-cachefs@redhat.com \
--cc=linux-cifs-client@lists.samba.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernerl.org \
--cc=mingo@elte.hu \
--cc=nfsv4@linux-nfs.org \
--cc=steved@redhat.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).