linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Paris <eparis@redhat.com>
To: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org
Cc: viro@zeniv.linux.org.uk, jmorris@namei.org, npiggin@suse.de,
	eparis@redhat.com, zohar@us.ibm.com, jack@suse.cz,
	jmalicki@metacarta.com, dsmith@redhat.com, serue@us.ibm.com,
	hch@lst.de, john@johnmccutchan.com, rlove@rlove.org,
	ebiederm@xmission.com, heiko.carstens@de.ibm.com,
	penguin-kernel@I-love.SAKURA.ne.jp, mszeredi@suse.cz,
	jens.axboe@oracle.com, akpm@linux-foundation.org, matthew@wil.cx,
	hugh.dickins@tiscali.co.uk, kamezawa.hiroyu@jp.fujitsu.com,
	nishimura@mxp.nes.nec.co.jp, davem@davemloft.net, arnd@arndb.de,
	eric.dumazet@gmail.com
Subject: [RFC PATCH 14/15] security: move ima_file_check() to lsm hook
Date: Fri, 04 Dec 2009 15:48:32 -0500	[thread overview]
Message-ID: <20091204204832.18286.19016.stgit@paris.rdu.redhat.com> (raw)
In-Reply-To: <20091204204646.18286.24853.stgit@paris.rdu.redhat.com>

From: Mimi Zohar <zohar@linux.vnet.ibm.com>

Move the ima_file_check() hook from the vfs into the LSM hook.

Signed-off-by: Mimi Zohar <zohar@linux.vnet.ibm.com>
Signed-off-by: Eric Paris <eparis@redhat.com>
---

 fs/open.c           |    7 -------
 security/security.c |    8 +++++++-
 2 files changed, 7 insertions(+), 8 deletions(-)

diff --git a/fs/open.c b/fs/open.c
index 10bd04e..25c1436 100644
--- a/fs/open.c
+++ b/fs/open.c
@@ -30,7 +30,6 @@
 #include <linux/audit.h>
 #include <linux/falloc.h>
 #include <linux/fs_struct.h>
-#include <linux/ima.h>
 
 #include "internal.h"
 
@@ -875,12 +874,6 @@ static struct file *__dentry_open(struct dentry *dentry, struct vfsmount *mnt,
 		}
 	}
 
-	error = ima_file_check(f);
-	if (error) {
-		fput(f);
-		f = ERR_PTR(error);
-	}
-
 	return f;
 
 cleanup_all:
diff --git a/security/security.c b/security/security.c
index fd2d450..a42586b 100644
--- a/security/security.c
+++ b/security/security.c
@@ -722,7 +722,13 @@ int security_file_receive(struct file *file)
 
 int security_dentry_open(struct file *file, const struct cred *cred)
 {
-	return security_ops->dentry_open(file, cred);
+	int ret;
+
+	ret = security_ops->dentry_open(file, cred);
+	if (ret)
+		return ret;
+
+	return ima_file_check(file);
 }
 
 int security_task_create(unsigned long clone_flags)

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2009-12-04 20:48 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-04 20:46 [RFC PATCH 01/15] shmem: do not call fput_filp on an initialized filp Eric Paris
2009-12-04 20:46 ` [RFC PATCH 02/15] shmem: use alloc_file instead of init_file Eric Paris
2009-12-05 20:26   ` Hugh Dickins
2009-12-04 20:47 ` [RFC PATCH 03/15] pipes: use alloc-file instead of duplicating code Eric Paris
2009-12-04 20:47 ` [RFC PATCH 04/15] inotify: use alloc_file instead of doing it internally Eric Paris
2009-12-04 20:47 ` [RFC PATCH 05/15] networking: rework socket to fd mapping using alloc-file Eric Paris
2009-12-04 20:47 ` [RFC PATCH 06/15] vfs: make init-file static Eric Paris
2009-12-04 20:47 ` [RFC PATCH 07/15] fs: move get_empty_filp() deffinition to internal.h Eric Paris
2009-12-04 20:47 ` [RFC PATCH 08/15] ima: valid return code from ima_inode_alloc Eric Paris
2009-12-04 20:47 ` [RFC PATCH 09/15] ima: only insert at inode creation time Eric Paris
2009-12-04 20:48 ` [RFC PATCH 10/15] IMA: clean up the IMA counts updating code Eric Paris
2009-12-04 20:48 ` [RFC PATCH 11/15] ima: call ima_inode_free ima_inode_free Eric Paris
2009-12-04 20:48 ` [RFC PATCH 12/15] ima-path-check rework Eric Paris
2009-12-05 20:30   ` Hugh Dickins
2009-12-04 20:48 ` [RFC PATCH 13/15] ima: rename ima_path_check to ima_file_check Eric Paris
2009-12-04 20:48 ` Eric Paris [this message]
2009-12-04 20:48 ` [RFC PATCH 15/15] ima: limit imbalance msg Eric Paris
2009-12-05 20:23 ` [RFC PATCH 01/15] shmem: do not call fput_filp on an initialized filp Hugh Dickins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091204204832.18286.19016.stgit@paris.rdu.redhat.com \
    --to=eparis@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=davem@davemloft.net \
    --cc=dsmith@redhat.com \
    --cc=ebiederm@xmission.com \
    --cc=eric.dumazet@gmail.com \
    --cc=hch@lst.de \
    --cc=heiko.carstens@de.ibm.com \
    --cc=hugh.dickins@tiscali.co.uk \
    --cc=jack@suse.cz \
    --cc=jens.axboe@oracle.com \
    --cc=jmalicki@metacarta.com \
    --cc=jmorris@namei.org \
    --cc=john@johnmccutchan.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=matthew@wil.cx \
    --cc=mszeredi@suse.cz \
    --cc=nishimura@mxp.nes.nec.co.jp \
    --cc=npiggin@suse.de \
    --cc=penguin-kernel@I-love.SAKURA.ne.jp \
    --cc=rlove@rlove.org \
    --cc=serue@us.ibm.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=zohar@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).