From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ingo Oeser <ioe-lkml@rameria.de>
Subject: Re: [PATCH 05/24] ceph: ref counted buffer
Date: Sat, 5 Dec 2009 02:31:23 +0100
Message-ID: <200912050231.23530.ioe-lkml@rameria.de>
References: <1259883691-1042-1-git-send-email-sage@newdream.net> <1259883691-1042-5-git-send-email-sage@newdream.net> <1259883691-1042-6-git-send-email-sage@newdream.net>
Mime-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
To: Sage Weil <sage@newdream.net>
Return-path: <linux-kernel-owner+glk-linux-kernel-3=40m.gmane.org-S932761AbZLEBbm@vger.kernel.org>
In-Reply-To: <1259883691-1042-6-git-send-email-sage@newdream.net>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

On Friday 04 December 2009, Sage Weil wrote:
> struct ceph_buffer is a simple ref-counted buffer.  We transparently
> choose between kmalloc for small buffers and vmalloc for large ones.
> 
> This is currently used only for allocating memory for xattr data.

Could you wrap parts of this refcounting logic around kref?
see #include <linux/kref.h> and lib/kref.c

It avoids a bug with memory areas for free and if anybody
optimizes or changes refcounting stuff, you get all changes for free :-)

Best Regards

Ingo Oeser