From: Nick Piggin <npiggin@suse.de>
To: Jan Kara <jack@suse.cz>
Cc: Al Viro <viro@ZenIV.linux.org.uk>,
Christoph Hellwig <hch@infradead.org>,
linux-fsdevel@vger.kernel.org
Subject: Re: [patch 3/5] tmpfs: convert to use the new truncate convention
Date: Thu, 10 Dec 2009 11:48:52 +1100 [thread overview]
Message-ID: <20091210004852.GA9601@nick> (raw)
In-Reply-To: <20091209144559.GC7044@quack.suse.cz>
On Wed, Dec 09, 2009 at 03:45:59PM +0100, Jan Kara wrote:
> On Tue 08-12-09 09:41:09, Nick Piggin wrote:
> > Cc: Christoph Hellwig <hch@lst.de>
> > Acked-by: Hugh Dickins <hugh.dickins@tiscali.co.uk>
> > Signed-off-by: Nick Piggin <npiggin@suse.de>
> ...
> > @@ -821,11 +824,11 @@ static void shmem_delete_inode(struct in
> > {
> > struct shmem_inode_info *info = SHMEM_I(inode);
> >
> > - if (inode->i_op->truncate == shmem_truncate) {
> > + if (inode->i_mapping->a_ops == &shmem_aops) {
> How about symlinks here? Originally we've truncated inode for them as
> well... BTW the check is really strange. Shouldn't we rather make it
> something like S_ISLNK || S_ISREG?
Yes you're right. I don't see why we can't use the mode check,
Hugh?
next prev parent reply other threads:[~2009-12-10 1:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-08 8:38 [patch 1/5] fs: truncate introduce new sequence Nick Piggin
2009-12-08 8:39 ` [patch 2/5] fs: convert simple fs to new truncate Nick Piggin
2009-12-09 14:39 ` Jan Kara
2009-12-10 5:15 ` Nick Piggin
2009-12-10 8:44 ` Boaz Harrosh
2009-12-10 7:57 ` Nick Piggin
2009-12-08 8:41 ` [patch 3/5] tmpfs: convert to use the new truncate convention Nick Piggin
2009-12-09 14:45 ` Jan Kara
2009-12-10 0:48 ` Nick Piggin [this message]
2009-12-08 8:42 ` [patch 4/5] ext2: " Nick Piggin
2009-12-09 14:57 ` Jan Kara
2009-12-10 1:11 ` Nick Piggin
2009-12-10 10:20 ` Jan Kara
2009-12-08 8:43 ` [patch 5/5] fat: " Nick Piggin
2009-12-09 15:08 ` Jan Kara
2009-12-09 14:38 ` [patch 1/5] fs: truncate introduce new sequence Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091210004852.GA9601@nick \
--to=npiggin@suse.de \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).