linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* pohmelfs needs I_LOCK
@ 2009-12-18 12:13 Geert Uytterhoeven
  2009-12-18 12:40 ` Evgeniy Polyakov
  0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2009-12-18 12:13 UTC (permalink / raw)
  To: Evgeniy Polyakov, Greg Kroah-Hartman, Christoph Hellwig, Al Viro
  Cc: Linux Kernel Development, linux-fsdevel, devel

There's a conflict in 2.6.33-rc1 between the following 2 commits:

commit ff8079d4f1016a12e34ab323737314f24127dd ("kill I_LOCK")
commit e3eec94dc91c39f2bd7939294b9cd4a65a82db44 ("Staging: pohmelfs: directory
operations")

drivers/staging/pohmelfs/dir.c: In function 'pohmelfs_remove_entry':
drivers/staging/pohmelfs/dir.c:725: error: 'I_LOCK' undeclared (first use in this function)
drivers/staging/pohmelfs/dir.c:725: error: (Each undeclared identifier is reported only once
drivers/staging/pohmelfs/dir.c:725: error: for each function it appears in.)

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: pohmelfs needs I_LOCK
  2009-12-18 12:13 pohmelfs needs I_LOCK Geert Uytterhoeven
@ 2009-12-18 12:40 ` Evgeniy Polyakov
  0 siblings, 0 replies; 2+ messages in thread
From: Evgeniy Polyakov @ 2009-12-18 12:40 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Greg Kroah-Hartman, Christoph Hellwig, Al Viro,
	Linux Kernel Development, linux-fsdevel, devel

Hi.

On Fri, Dec 18, 2009 at 01:13:38PM +0100, Geert Uytterhoeven (geert@linux-m68k.org) wrote:
> There's a conflict in 2.6.33-rc1 between the following 2 commits:
> 
> commit ff8079d4f1016a12e34ab323737314f24127dd ("kill I_LOCK")
> commit e3eec94dc91c39f2bd7939294b9cd4a65a82db44 ("Staging: pohmelfs: directory
> operations")
> 
> drivers/staging/pohmelfs/dir.c: In function 'pohmelfs_remove_entry':
> drivers/staging/pohmelfs/dir.c:725: error: 'I_LOCK' undeclared (first use in this function)
> drivers/staging/pohmelfs/dir.c:725: error: (Each undeclared identifier is reported only once
> drivers/staging/pohmelfs/dir.c:725: error: for each function it appears in.)

This should fix it.

Signed-off-by: Evgeniy Polyakov <zbr@ioremap.net>

diff --git a/drivers/staging/pohmelfs/dir.c b/drivers/staging/pohmelfs/dir.c
index 6c5b261..aacd25b 100644
--- a/drivers/staging/pohmelfs/dir.c
+++ b/drivers/staging/pohmelfs/dir.c
@@ -722,8 +722,6 @@ static int pohmelfs_remove_entry(struct inode *dir, struct dentry *dentry)
 		if (inode->i_nlink)
 			inode_dec_link_count(inode);
 	}
-	dprintk("%s: inode: %p, lock: %ld, unhashed: %d.\n",
-		__func__, pi, inode->i_state & I_LOCK, hlist_unhashed(&inode->i_hash));
 
 	return err;
 }


-- 
	Evgeniy Polyakov

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-12-18 12:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-18 12:13 pohmelfs needs I_LOCK Geert Uytterhoeven
2009-12-18 12:40 ` Evgeniy Polyakov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).