From: Christoph Hellwig <hch@lst.de>
To: Liuwenyi <qingshenlwy@gmail.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2 00/12]posix_acl: Add the check items
Date: Mon, 21 Dec 2009 13:37:27 +0100 [thread overview]
Message-ID: <20091221123654.GA9201@lst.de> (raw)
In-Reply-To: <4B2F6153.8010609@gmail.com>
I like taking these checks into posix_acl_valid, but I think the patch
submission needs a bit more work.
All the patches are extremly whitespace mangled. And I don't think
splitting them up makes a whole lot of sense, when we do API changes
like this we usually fix up all callers. So please try to fix your
mailer, merged them all into one, and maybe also chose a more
descriptive subject line, e.g.
Subject: take checks for NULL and error pointers into posix_acl_valid()
And btw, at least the XFS change seems incorrect - previously we
returned NULL acl pointer and this patch changes it to -EINVAL.
next parent reply other threads:[~2009-12-21 12:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4B2F6153.8010609@gmail.com>
2009-12-21 12:37 ` Christoph Hellwig [this message]
2009-12-21 14:15 ` [PATCHv2 00/12]posix_acl: Add the check items liu weni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091221123654.GA9201@lst.de \
--to=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=qingshenlwy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).