From: Christoph Hellwig <hch@infradead.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Wu Fengguang <fengguang.wu@intel.com>,
Andi Kleen <andi@firstfloor.org>,
Andrew Morton <akpm@linux-foundation.org>,
Quentin Barnes <qbarnes+nfs@yahoo-inc.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
Nick Piggin <npiggin@suse.de>,
Steven Whitehouse <swhiteho@redhat.com>,
David Howells <dhowells@redhat.com>,
Al Viro <viro@zeniv.linux.org.uk>,
Jonathan Corbet <corbet@lwn.net>,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [RFC][PATCH v3] readahead: introduce O_RANDOM for POSIX_FADV_RANDOM
Date: Mon, 4 Jan 2010 02:33:28 -0500 [thread overview]
Message-ID: <20100104073328.GA3422@infradead.org> (raw)
In-Reply-To: <20100104161719.a0bb35ad.sfr@canb.auug.org.au>
On Mon, Jan 04, 2010 at 04:17:19PM +1100, Stephen Rothwell wrote:
> > @@ -80,6 +80,10 @@
> > #define O_NDELAY O_NONBLOCK
> > #endif
> >
> > +#ifndef O_RANDOM
> > +#define O_RANDOM 010000000 /* random access pattern hint */
> > +#endif
>
> This value conflicts with O_CLOEXEC on alpha and parisc and O_NOATIME on
> sparc.
Also when I tried to use this value for O_RSYNC and tested it I could
not actually see it getting propagated by the open code.
Eitherway I don't think an O_ value is a good idea for a simple access
pattern hint.
next prev parent reply other threads:[~2010-01-04 7:33 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20091225000717.GA26949@yahoo-inc.com>
[not found] ` <87aax18xms.fsf@basil.nowhere.org>
2009-12-30 5:15 ` [RFC][PATCH] Disabling read-ahead makes I/O of large reads small Wu Fengguang
2009-12-30 5:17 ` [RFC][PATCH 1/2] readahead: replace ra->mmap_miss with ra->flags Wu Fengguang
2009-12-30 5:24 ` [RFC][PATCH 2/2] readahead: avoid page-by-page reads on POSIX_FADV_RANDOM Wu Fengguang
2009-12-30 18:02 ` Andi Kleen
2009-12-31 1:39 ` Wu Fengguang
2009-12-31 2:53 ` Wu Fengguang
2009-12-31 3:03 ` Wu Fengguang
2009-12-31 4:31 ` [RFC][PATCH v2] readahead: introduce O_RANDOM_READ for POSIX_FADV_RANDOM Wu Fengguang
2010-01-08 13:08 ` Christoph Hellwig
2010-01-09 13:59 ` Wu Fengguang
2010-01-09 14:01 ` Wu Fengguang
2010-01-04 4:50 ` [RFC][PATCH v3] readahead: introduce O_RANDOM " Wu Fengguang
2010-01-04 5:17 ` Stephen Rothwell
2010-01-04 7:33 ` Christoph Hellwig [this message]
2010-01-04 12:56 ` [RFC][PATCH v4] " Wu Fengguang
2010-01-05 2:03 ` Stephen Rothwell
2010-01-05 2:26 ` Wu Fengguang
2010-01-05 2:28 ` Stephen Rothwell
2010-01-05 2:45 ` Wu Fengguang
2010-01-05 5:21 ` Eric Paris
2010-01-05 3:18 ` [RFC][PATCH v5] " Wu Fengguang
2010-01-05 3:27 ` Wu Fengguang
2010-01-04 16:50 ` [RFC][PATCH v3] " Quentin Barnes
2010-01-04 18:57 ` Andreas Dilger
2010-01-04 5:20 ` Minchan Kim
2010-01-04 12:16 ` Wu Fengguang
2010-01-05 1:46 ` Minchan Kim
2010-01-05 2:16 ` Wu Fengguang
2010-01-05 3:40 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100104073328.GA3422@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=corbet@lwn.net \
--cc=dhowells@redhat.com \
--cc=fengguang.wu@intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=npiggin@suse.de \
--cc=qbarnes+nfs@yahoo-inc.com \
--cc=sfr@canb.auug.org.au \
--cc=swhiteho@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).