From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wu Fengguang Subject: Re: [RFC][PATCH v4] readahead: introduce O_RANDOM for POSIX_FADV_RANDOM Date: Tue, 5 Jan 2010 10:26:50 +0800 Message-ID: <20100105022650.GB29428@localhost> References: <20091225000717.GA26949@yahoo-inc.com> <87aax18xms.fsf@basil.nowhere.org> <20091230051540.GA16308@localhost> <20091230052402.GB26364@localhost> <873a2s8hmp.fsf@basil.nowhere.org> <20100104045020.GA21021@localhost> <20100104161719.a0bb35ad.sfr@canb.auug.org.au> <20100104073328.GA3422@infradead.org> <20100104125620.GB12266@localhost> <20100105130322.006c03ee.sfr@canb.auug.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoph Hellwig , Andi Kleen , Andrew Morton , Quentin Barnes , "linux-kernel@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , Nick Piggin , Steven Whitehouse , David Howells , Al Viro , Jonathan Corbet To: Stephen Rothwell Return-path: Content-Disposition: inline In-Reply-To: <20100105130322.006c03ee.sfr@canb.auug.org.au> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Tue, Jan 05, 2010 at 10:03:22AM +0800, Stephen Rothwell wrote: > On Mon, 4 Jan 2010 20:56:20 +0800 Wu Fengguang wrote: > > > > For now I'll use bit 040000000, which happen to equal to > > FMODE_NONOTIFY and will be masked out by __dentry_open() > > in the very beginning. > > But also clashes with __O_SYNC on sparc, sorry. I am not sure how we are > meant to reasonably choose these values any more ... Where is it? I cannot grep find one in arch/. There is one defined in include/asm-generic/fcntl.h: #ifndef O_SYNC #define __O_SYNC 04000000 #define O_SYNC (__O_SYNC|O_DSYNC) #endif However it has one less '0' :) Thanks, Fengguang