From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH] fs: O_* bit numbers uniqueness check
Date: Wed, 6 Jan 2010 10:48:14 -0500
Message-ID: <20100106154814.GA5172@infradead.org>
References: <20100106065526.GB11368@localhost>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Andrew Morton <akpm@linux-foundation.org>,
	David Miller <davem@davemloft.net>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	Al Viro <viro@zeniv.linux.org.uk>,
	Christoph Hellwig <hch@infradead.org>,
	Eric Paris <eparis@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-fsdevel@vger.kernel.org
To: Wu Fengguang <fengguang.wu@intel.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from bombadil.infradead.org ([18.85.46.34]:50203 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755184Ab0AFPsl (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Wed, 6 Jan 2010 10:48:41 -0500
Content-Disposition: inline
In-Reply-To: <20100106065526.GB11368@localhost>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Wed, Jan 06, 2010 at 02:55:26PM +0800, Wu Fengguang wrote:
> The O_* bit numbers are defined in 20+ arch/*, and hence can silently
> overlap. Add a boot time check to ensure the uniqueness as suggested
> by David Miller.

The right fix is to stop overlyaing the FMODE_ flags into the O_
namespace.  Al has been working towards this.