From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] procfs: Fix refcnt leak on proc_self_follow_link()
 error path
Date: Wed, 13 Jan 2010 16:25:04 -0800
Message-ID: <20100113162504.1c06c5e6.akpm@linux-foundation.org>
References: <87aawkjxlf.fsf@devron.myhome.or.jp>
	<20100113194300.GA4673@ZenIV.linux.org.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
To: Al Viro <viro@ZenIV.linux.org.uk>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from smtp1.linux-foundation.org ([140.211.169.13]:56808 "EHLO
	smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1756660Ab0ANAZg (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Wed, 13 Jan 2010 19:25:36 -0500
In-Reply-To: <20100113194300.GA4673@ZenIV.linux.org.uk>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Wed, 13 Jan 2010 19:43:01 +0000
Al Viro <viro@ZenIV.linux.org.uk> wrote:

> On Tue, Jan 12, 2010 at 03:38:36AM +0900, OGAWA Hirofumi wrote:
> > 
> > If ->follow_link handler return the error, it should decrement
> > nd->path refcnt.
> > 
> > This patch fix it.
> 
> It's OK for -stable, but for the next tree... not really.  I'd rather
> kill vfs_follow_link() uses here and in gfs2; see #untested in vfs-2.6.git
> for details.

Confused.  Is #untested planned for 2.6.33?  If not, how do we fix this
bug in .33?