From mboxrd@z Thu Jan  1 00:00:00 1970
From: Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: [PATCH] procfs: Fix refcnt leak on proc_self_follow_link() error
 path
Date: Wed, 13 Jan 2010 19:43:01 +0000
Message-ID: <20100113194300.GA4673@ZenIV.linux.org.uk>
References: <87aawkjxlf.fsf@devron.myhome.or.jp>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Return-path: <linux-kernel-owner+glk-linux-kernel-3=40m.gmane.org-S1753982Ab0AMTnH@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <87aawkjxlf.fsf@devron.myhome.or.jp>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

On Tue, Jan 12, 2010 at 03:38:36AM +0900, OGAWA Hirofumi wrote:
> 
> If ->follow_link handler return the error, it should decrement
> nd->path refcnt.
> 
> This patch fix it.

It's OK for -stable, but for the next tree... not really.  I'd rather
kill vfs_follow_link() uses here and in gfs2; see #untested in vfs-2.6.git
for details.