From mboxrd@z Thu Jan  1 00:00:00 1970
From: Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: [PATCH] ecryptfs: Fix refcnt leak on ecryptfs_follow_link()
 error path
Date: Wed, 13 Jan 2010 19:44:58 +0000
Message-ID: <20100113194458.GB4673@ZenIV.linux.org.uk>
References: <87my0kjxpd.fsf@devron.myhome.or.jp>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Tyler Hicks <tyhicks@linux.vnet.ibm.com>,
	Dustin Kirkland <kirkland@canonical.com>,
	ecryptfs-devel@lists.launchpad.net, linux-kernel@vger.kernel.org,
	linux-fsdevel@vger.kernel.org
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Return-path: <linux-kernel-owner+glk-linux-kernel-3=40m.gmane.org-S1754401Ab0AMTpG@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <87my0kjxpd.fsf@devron.myhome.or.jp>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

On Tue, Jan 12, 2010 at 03:36:14AM +0900, OGAWA Hirofumi wrote:
> 
> If ->follow_link handler return the error, it should decrement
> nd->path refcnt. But, ecryptfs_follow_link() doesn't decrement.
> 
> This patch fix it by using usual nd_set_link() style error handling,
> instead of playing with nd->path.

Applied.