From: Al Viro <viro@ZenIV.linux.org.uk>
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/2] vfs: Fix refcnt leak with __do_follow_link() in do_filp_open()
Date: Wed, 13 Jan 2010 20:07:11 +0000 [thread overview]
Message-ID: <20100113200711.GD19799@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20100113195059.GC4673@ZenIV.linux.org.uk>
On Wed, Jan 13, 2010 at 07:51:00PM +0000, Al Viro wrote:
> Point, but... that's not the way I'd do it (again, see #untested for the
> direction it's heading). What we ought to do is simply "put ourselves
> in trust-no-one mode (LOOKUP_REVAL) and restart the entire thing; if
> we'd already been through that, fail immediately".
>
> And yes, it needs to be pulled in front of queue and go in before .34.
> Will do shortly.
See commit 1fe1244faf0e862342bd2ae29e341cc957469aee in vfs-2.6.git#for-linus
(that's going to be rc5 fixes push tonight, after several more things get
shifted there).
next prev parent reply other threads:[~2010-01-13 20:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-11 18:33 [PATCH 1/2] vfs: cleanup path_to_nameidata() OGAWA Hirofumi
2010-01-11 18:35 ` [PATCH 2/2] vfs: Fix refcnt leak with __do_follow_link() in do_filp_open() OGAWA Hirofumi
2010-01-13 19:51 ` Al Viro
2010-01-13 20:07 ` Al Viro [this message]
2010-01-14 3:32 ` OGAWA Hirofumi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100113200711.GD19799@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=hirofumi@mail.parknet.co.jp \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).