From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 1/2] make sure data is on disk before calling ->write_inode Date: Thu, 14 Jan 2010 07:21:06 +0100 Message-ID: <20100114062106.GA16739@lst.de> References: <20100111173047.GA6852@lst.de> <20100113162154.f7e7af49.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoph Hellwig , viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, Trond.Myklebust@netapp.com, dhowells@redhat.com To: Andrew Morton Return-path: Received: from verein.lst.de ([213.95.11.210]:47455 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751411Ab0ANGV4 (ORCPT ); Thu, 14 Jan 2010 01:21:56 -0500 Content-Disposition: inline In-Reply-To: <20100113162154.f7e7af49.akpm@linux-foundation.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, Jan 13, 2010 at 04:21:54PM -0800, Andrew Morton wrote: > hm, yeah, it's hard to see how this reordering can harm throughput much. > > nfs_write_inode() has vanished in linux-enxt so I just dropped all the > nfs parts of these two patches. You might want to check that. That's because linux-next has an ugly workaround for the all calling conventions. The nfs updates in -next should be dropped / reworked instead.