From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH] fs/binfmt_elf.c: fix a do-while statement. Date: Tue, 26 Jan 2010 18:07:52 -0800 Message-ID: <20100126180752.951509b5.akpm@linux-foundation.org> References: <20100126160632.3bdbe172.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, Alexander Viro , Roland McGrath , WANG Cong , Hugh Dickins , linux-fsdevel@vger.kernel.org To: Thiago Farina Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Tue, 26 Jan 2010 23:44:29 -0200 Thiago Farina wrote: > > It is somewhat unconventional coding style and it'd be good if > > checkpatch were to warn so that we don't _add_ such things to the tree. > > > > But IMO it's such a minor thing that once it _is_ in the tree, it's not > > really worth the patch noise to go and fix it up. > > Yeah, much noise for a small thing. I will not fix more warnings like > this in future. I'd be OK with fixing things like this as part of a larger "fs/binfmt_elf.c: coding-style fixes" or "fs/*elf.c: ...", etc. One big hit. It's the little dribble of one-line fixes which I'd prefer to avoid.