From: Al Viro <viro@ZenIV.linux.org.uk>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: vaurora@redhat.com, linux-fsdevel@vger.kernel.org,
hch@infradead.org, ezk@cs.sunysb.edu, linuxram@us.ibm.com
Subject: Re: [PATCH] VFS: Clean up shared mount flag propagation
Date: Fri, 29 Jan 2010 13:36:14 +0000 [thread overview]
Message-ID: <20100129133614.GP19799@ZenIV.linux.org.uk> (raw)
In-Reply-To: <E1NamOn-00006P-39@pomaz-ex.szeredi.hu>
On Fri, Jan 29, 2010 at 09:40:17AM +0100, Miklos Szeredi wrote:
> On Tue, 26 Jan 2010, Al Viro wrote:
> > On Tue, Jan 26, 2010 at 02:20:47PM -0500, Valerie Aurora wrote:
> > > Al, you might have already fixed this as part of your mount flag
> > > rewrite, but here's a patch to clean up some problems with shared
> > > mount flag propagation that I ran into while working on union mounts.
> > > Against 2.6.32.
> >
> > Umm... OK by me; I'll put that into for-next on tonight's push.
>
> The patch as committed to "untested" is wrong, MNT_SHARED_MASK needs
> to be MNT_UNBINDABLE | MNT_SHARED, because of the code in
> do_remount().
D'oh... Sorry, my fault. Fixed and pushed (I prefer separate #define
for that one, actually). Should propagate from hera shortly...
next prev parent reply other threads:[~2010-01-29 13:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-26 19:20 [PATCH] VFS: Clean up shared mount flag propagation Valerie Aurora
2010-01-26 19:53 ` Al Viro
2010-01-29 8:40 ` Miklos Szeredi
2010-01-29 13:36 ` Al Viro [this message]
2010-01-29 18:26 ` Valerie Aurora
2010-01-29 17:52 ` Ram Pai
2010-01-29 18:39 ` Valerie Aurora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100129133614.GP19799@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=ezk@cs.sunysb.edu \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linuxram@us.ibm.com \
--cc=miklos@szeredi.hu \
--cc=vaurora@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).