From mboxrd@z Thu Jan  1 00:00:00 1970
From: Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: [PATCH] VFS: Clean up shared mount flag propagation
Date: Fri, 29 Jan 2010 13:36:14 +0000
Message-ID: <20100129133614.GP19799@ZenIV.linux.org.uk>
References: <20100126192047.GB32353@shell> <20100126195342.GL19799@ZenIV.linux.org.uk> <E1NamOn-00006P-39@pomaz-ex.szeredi.hu>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: vaurora@redhat.com, linux-fsdevel@vger.kernel.org,
	hch@infradead.org, ezk@cs.sunysb.edu, linuxram@us.ibm.com
To: Miklos Szeredi <miklos@szeredi.hu>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from zeniv.linux.org.uk ([195.92.253.2]:42923 "EHLO
	ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753725Ab0A2Ng0 (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Fri, 29 Jan 2010 08:36:26 -0500
Content-Disposition: inline
In-Reply-To: <E1NamOn-00006P-39@pomaz-ex.szeredi.hu>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Fri, Jan 29, 2010 at 09:40:17AM +0100, Miklos Szeredi wrote:
> On Tue, 26 Jan 2010, Al Viro wrote:
> > On Tue, Jan 26, 2010 at 02:20:47PM -0500, Valerie Aurora wrote:
> > > Al, you might have already fixed this as part of your mount flag
> > > rewrite, but here's a patch to clean up some problems with shared
> > > mount flag propagation that I ran into while working on union mounts.
> > > Against 2.6.32.
> > 
> > Umm...  OK by me; I'll put that into for-next on tonight's push.
> 
> The patch as committed to "untested" is wrong, MNT_SHARED_MASK needs
> to be MNT_UNBINDABLE | MNT_SHARED, because of the code in
> do_remount().

D'oh...  Sorry, my fault.  Fixed and pushed (I prefer separate #define
for that one, actually).  Should propagate from hera shortly...