From mboxrd@z Thu Jan 1 00:00:00 1970 From: Valerie Aurora Subject: Re: [PATCH] VFS: Clean up shared mount flag propagation Date: Fri, 29 Jan 2010 13:26:15 -0500 Message-ID: <20100129182614.GA432@shell> References: <20100126192047.GB32353@shell> <20100126195342.GL19799@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Al Viro , linux-fsdevel@vger.kernel.org, hch@infradead.org, ezk@cs.sunysb.edu, linuxram@us.ibm.com To: Miklos Szeredi Return-path: Received: from mx1.redhat.com ([209.132.183.28]:57221 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752407Ab0A2S06 (ORCPT ); Fri, 29 Jan 2010 13:26:58 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, Jan 29, 2010 at 09:40:17AM +0100, Miklos Szeredi wrote: > On Tue, 26 Jan 2010, Al Viro wrote: > > On Tue, Jan 26, 2010 at 02:20:47PM -0500, Valerie Aurora wrote: > > > Al, you might have already fixed this as part of your mount flag > > > rewrite, but here's a patch to clean up some problems with shared > > > mount flag propagation that I ran into while working on union mounts. > > > Against 2.6.32. > > > > Umm... OK by me; I'll put that into for-next on tonight's push. > > The patch as committed to "untested" is wrong, MNT_SHARED_MASK needs > to be MNT_UNBINDABLE | MNT_SHARED, because of the code in > do_remount(). My bad - I made the patch against 2.6.32, which doesn't have this code. Without this, the only use of this mask was in set_mnt_shared(), which immediately set it again. :) -VAL