From: Jan Kara <jack@suse.cz>
To: Dmitry Monakhov <dmonakhov@openvz.org>
Cc: linux-fsdevel@vger.kernel.org, jack@suse.cz
Subject: Re: [PATCH 3/3] quota: add generic treeid quota support
Date: Tue, 2 Feb 2010 17:10:06 +0100 [thread overview]
Message-ID: <20100202161005.GJ7056@quack.suse.cz> (raw)
In-Reply-To: <1265122826-5370-4-git-send-email-dmonakhov@openvz.org>
On Tue 02-02-10 18:00:25, Dmitry Monakhov wrote:
> Just introduce new and update macros.
> It will be used later.
...
> #define V2_INITQVERSIONS {\
> 1, /* USRQUOTA */\
> 1 /* GRPQUOTA */\
> + 1 /* TRPQUOTA */\
> }
This won't compile...
> /* First generic header */
> diff --git a/include/linux/quota.h b/include/linux/quota.h
> index 7f06086..dc6d84e 100644
> --- a/include/linux/quota.h
> +++ b/include/linux/quota.h
> @@ -36,11 +36,12 @@
> #include <linux/errno.h>
> #include <linux/types.h>
>
> -#define __DQUOT_VERSION__ "dquot_6.5.2"
> +#define __DQUOT_VERSION__ "dquot_7.0.0"
;-) Hmm, not that this version would matter but 6.6.0 would look
more logical to me. But I'll leave that up to you.
Otherwise I'm fine with the patch.
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next prev parent reply other threads:[~2010-02-02 16:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-02 15:00 [PATCH 0/3] quota: RFC add extend quota types Dmitry Monakhov
2010-02-02 15:00 ` [PATCH 1/3] quota: generalize quota transfer interface Dmitry Monakhov
2010-02-02 15:00 ` [PATCH 2/3] quota: introduce get_id callback Dmitry Monakhov
2010-02-02 15:00 ` [PATCH 3/3] quota: add generic treeid quota support Dmitry Monakhov
2010-02-02 16:10 ` Jan Kara [this message]
2010-02-02 16:05 ` [PATCH 2/3] quota: introduce get_id callback Jan Kara
2010-02-03 5:38 ` Dmitry Monakhov
2010-02-03 10:47 ` Jan Kara
2010-02-03 19:54 ` Dmitry Monakhov
2010-02-02 15:48 ` [PATCH 1/3] quota: generalize quota transfer interface Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100202161005.GJ7056@quack.suse.cz \
--to=jack@suse.cz \
--cc=dmonakhov@openvz.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).