From: Wu Fengguang <fengguang.wu@intel.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Greg KH <greg@kroah.com>,
Andrew Morton <akpm@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@suse.de>,
LKML <linux-kernel@vger.kernel.org>,
Linux Memory Management List <linux-mm@kvack.org>,
Andi Kleen <andi@firstfloor.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"stable@kernel.org" <stable@kernel.org>,
"juha_motorsportcom@luukku.com" <juha_motorsportcom@luukku.com>
Subject: Re: [stable] [PATCH] devmem: check vmalloc address on kmem read/write
Date: Thu, 4 Feb 2010 11:18:54 +0800 [thread overview]
Message-ID: <20100204031854.GA14324@localhost> (raw)
In-Reply-To: <20100204115801.cac7c342.kamezawa.hiroyu@jp.fujitsu.com>
On Thu, Feb 04, 2010 at 10:58:01AM +0800, KAMEZAWA Hiroyuki wrote:
> On Thu, 4 Feb 2010 10:42:02 +0800
> Wu Fengguang <fengguang.wu@intel.com> wrote:
>
> > From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> >
> > commit 325fda71d0badc1073dc59f12a948f24ff05796a upstream.
> >
> > Otherwise vmalloc_to_page() will BUG().
> >
> > This also makes the kmem read/write implementation aligned with mem(4):
> > "References to nonexistent locations cause errors to be returned." Here
> > we return -ENXIO (inspired by Hugh) if no bytes have been transfered
> > to/from user space, otherwise return partial read/write results.
> >
>
> Wu-san, I have additonal fix to this patch. Now, *ppos update is unstable..
> Could you make merged one ?
> Maybe this one makes the all behavior clearer.
>
> ==
> This is a more fix for devmem-check-vmalloc-address-on-kmem-read-write.patch
> Now, the condition for updating *ppos is not good. (it's updated even if EFAULT
> occurs..). This fixes that.
>
>
> Reported-by: "Juha Leppanen" <juha_motorsportcom@luukku.com>
Sorry, can you elaborate the problem? How it break the application?
It looks that do_generic_file_read() also updates *ppos progressively,
no one complains about that.
Thanks,
Fengguang
next prev parent reply other threads:[~2010-02-04 3:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-22 4:59 [PATCH 0/4] devmem and readahead fixes for 2.6.33 Wu Fengguang
2010-01-22 4:59 ` [PATCH 1/4] devmem: check vmalloc address on kmem read/write Wu Fengguang
2010-01-22 4:59 ` [PATCH 2/4] devmem: fix kmem write bug on memory holes Wu Fengguang
2010-01-22 4:59 ` [PATCH 3/4] vfs: take f_lock on modifying f_mode after open time Wu Fengguang
2010-01-22 4:59 ` [PATCH 4/4] readahead: introduce FMODE_RANDOM for POSIX_FADV_RANDOM Wu Fengguang
2010-01-22 5:31 ` [PATCH 0/4] devmem and readahead fixes for 2.6.33 Greg KH
2010-01-27 0:50 ` Andrew Morton
2010-01-27 1:39 ` Greg KH
2010-01-27 2:45 ` Wu Fengguang
2010-02-03 23:47 ` [stable] " Greg KH
2010-02-04 2:42 ` [stable] [PATCH] devmem: check vmalloc address on kmem read/write Wu Fengguang
2010-02-04 2:43 ` [stable] [PATCH] devmem: fix kmem write bug on memory holes Wu Fengguang
2010-02-04 2:58 ` [stable] [PATCH] devmem: check vmalloc address on kmem read/write KAMEZAWA Hiroyuki
2010-02-04 3:18 ` Wu Fengguang [this message]
2010-02-04 3:27 ` KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100204031854.GA14324@localhost \
--to=fengguang.wu@intel.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=juha_motorsportcom@luukku.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).