From mboxrd@z Thu Jan  1 00:00:00 1970
From: Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: [WTF] ... is going on with current->fs->{root,mnt} accesses in
 pohmelfs
Date: Wed, 10 Feb 2010 11:00:11 +0000
Message-ID: <20100210110011.GN30031@ZenIV.linux.org.uk>
References: <20100210100428.GL30031@ZenIV.linux.org.uk>
 <20100210101246.GA3509@ioremap.net>
 <20100210102422.GM30031@ZenIV.linux.org.uk>
 <20100210104515.GA6207@ioremap.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
To: Evgeniy Polyakov <zbr@ioremap.net>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from zeniv.linux.org.uk ([195.92.253.2]:40041 "EHLO
	ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752760Ab0BJLAM (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Wed, 10 Feb 2010 06:00:12 -0500
Content-Disposition: inline
In-Reply-To: <20100210104515.GA6207@ioremap.net>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Wed, Feb 10, 2010 at 01:45:15PM +0300, Evgeniy Polyakov wrote:

> > To mountpoint or to fs root?  And what's going on with d_find_alias()?
> 
> To root if it happend to be under mountpoint.

HUH?  How the hell can root of filesystem be under the mountpoint of
that filesystem?  What are you talking about?

> > AFAICS, you are doing that for regular files as well as directories,
> > and you do support link(2) in there, so dentry (and path) obtained from
> > that will be random.
> 
> Not exactly random, but can change.
> Links support is rather subtle because of that, yes.
> 
> Plan was to add external attribute or increase inode size to include
> parent name, but when I coded that it was so messy in respect of
> renames, that was dropped.

Why not use the dentries you've been given by VFS?