From: Evgeniy Polyakov <zbr@ioremap.net>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [WTF] ... is going on with current->fs->{root,mnt} accesses in pohmelfs
Date: Thu, 11 Feb 2010 18:08:05 +0300 [thread overview]
Message-ID: <20100211150805.GA18705@ioremap.net> (raw)
In-Reply-To: <20100211030253.GQ30031@ZenIV.linux.org.uk>
On Thu, Feb 11, 2010 at 03:02:54AM +0000, Al Viro (viro@ZenIV.linux.org.uk) wrote:
> Um. You do realize that d_move() happens with none of your locks held,
> right? It's done in vfs_rename_{other,dir}() and the only thing held
> is s_vfs_rename_sem and i_mutex on parents. How could your code in
> writeback be able to distinguish
No, it happens with my lock held. It is not a lock, but kind of
IO delegation, i.e. it is not dropped when rename or other protected
operation completed. Instead another client sends request to grab it and
server asks current holder to drop cache, perform writeback or whatever
else is needed.
It can be a problem though if d_move() is called outside of path
protected by the VFS dir operations like rename/created/unlink and so
on, i.e. on behalf of some entity in the kernel which decides to move
dentries on itself. In this case POHMELFS is not protected.
--
Evgeniy Polyakov
next prev parent reply other threads:[~2010-02-11 15:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-10 10:04 [WTF] ... is going on with current->fs->{root,mnt} accesses in pohmelfs Al Viro
2010-02-10 10:12 ` Evgeniy Polyakov
2010-02-10 10:24 ` Al Viro
2010-02-10 10:45 ` Evgeniy Polyakov
2010-02-10 11:00 ` Al Viro
2010-02-10 11:11 ` Evgeniy Polyakov
2010-02-10 11:59 ` Al Viro
2010-02-10 13:30 ` Evgeniy Polyakov
2010-02-10 21:02 ` Al Viro
2010-02-10 21:29 ` Evgeniy Polyakov
2010-02-11 3:02 ` Al Viro
2010-02-11 15:08 ` Evgeniy Polyakov [this message]
2010-02-11 17:10 ` Al Viro
2010-02-11 19:13 ` Evgeniy Polyakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100211150805.GA18705@ioremap.net \
--to=zbr@ioremap.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).