From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH v2] vfs: add NOFOLLOW flag to umount(2) Date: Thu, 11 Feb 2010 12:21:00 -0500 Message-ID: <20100211172100.GA28533@infradead.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: viro@ZenIV.linux.org.uk, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Eugene Teo , Michael Kerrisk , Bodo Eggert <7eggert@web.de> To: Miklos Szeredi Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Wed, Feb 10, 2010 at 12:15:53PM +0100, Miklos Szeredi wrote: > - renamed flag to UMOUNT_NOFOLLOW > - added UMOUNT_UNUSED for feature detection Umm, why? MNT_ certainly isn't the best naming for unmount flags, but switching convention after we had a few doesn't make any sense.