From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH] fs: Add flags to __d_path for suppressing suffix and mapping /proc/self Date: Mon, 15 Feb 2010 11:15:23 -0500 Message-ID: <20100215161523.GA31908@infradead.org> References: <201002152311.IGC00525.SFOVtLJQFMOHFO@I-love.SAKURA.ne.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: viro@ZenIV.linux.org.uk, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: Tetsuo Handa Return-path: Content-Disposition: inline In-Reply-To: <201002152311.IGC00525.SFOVtLJQFMOHFO@I-love.SAKURA.ne.jp> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Mon, Feb 15, 2010 at 11:11:37PM +0900, Tetsuo Handa wrote: > This patch allows __d_path() to > (1) suppress " (deleted)" suffix if dentry was already deleted This part looks fine to me. > (2) convert /proc/PID to /proc/self if dentry is under /proc/self directory This not. If you security module is broken enough to require special casing /proc/pid entries that's your business, but there's not reason to put ugly hacks into core code for that.