From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 4/4] quota: add generic subtree quota support Date: Tue, 16 Feb 2010 03:14:26 -0500 Message-ID: <20100216081426.GA2622@infradead.org> References: <1266298312-25885-1-git-send-email-dmonakhov@openvz.org> <1266298312-25885-2-git-send-email-dmonakhov@openvz.org> <1266298312-25885-3-git-send-email-dmonakhov@openvz.org> <1266298312-25885-4-git-send-email-dmonakhov@openvz.org> <1266298312-25885-5-git-send-email-dmonakhov@openvz.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, jack@suse.cz To: Dmitry Monakhov Return-path: Received: from bombadil.infradead.org ([18.85.46.34]:58555 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932729Ab0BPIO1 (ORCPT ); Tue, 16 Feb 2010 03:14:27 -0500 Content-Disposition: inline In-Reply-To: <1266298312-25885-5-git-send-email-dmonakhov@openvz.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue, Feb 16, 2010 at 08:31:52AM +0300, Dmitry Monakhov wrote: > After this patch it is possible to implement fs-speciffic > subtree quota part. > > Signed-off-by: Dmitry Monakhov > --- > fs/quota/dquot.c | 5 +++++ > fs/quota/quotaio_v2.h | 6 ++++-- > include/linux/quota.h | 6 ++++-- > 3 files changed, 13 insertions(+), 4 deletions(-) Please call this project quota, and instead of introducing the get_id callback make it entirely generic. There's no point in adding artifical differences just at the point where I'm doing the long overdue consolidation of the XFS quota support and the "VFS" quote bits.